Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run hydration tests in both static-optimized and non-static-optimized modes #4586

Closed
nolanlawson opened this issue Sep 27, 2024 · 1 comment · Fixed by #4657
Closed

Run hydration tests in both static-optimized and non-static-optimized modes #4586

nolanlawson opened this issue Sep 27, 2024 · 1 comment · Fixed by #4657
Labels
ci tests

Comments

@nolanlawson
Copy link
Collaborator

We have some hydration Karma tests that implicitly disable the static content optimization by adding lwc:spread. This is a bit repetative and fragile – it will break if lwc:spread ever becomes static-optimized.

Instead, we should do what we do with the regular Karma tests and have a mode like:

DISABLE_STATIC_CONTENT_OPTIMIZATION=1 yarn hydration:test

This would disable the static content optimization explicitly for all hydration tests.
@nolanlawson
Copy link
Collaborator Author

Discovered during testing: #4656

nolanlawson added a commit that referenced this issue Oct 17, 2024
@nolanlawson
test(hydration): test non-static-optimized
105e375 
Fixes #4586
@nolanlawson nolanlawson mentioned this issue Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(hydration): test non-static-optimized salesforce/lwc
1 participant
@nolanlawson