test(hydration): test non-static-optimized #4657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Oct 17, 2024
| const hasMatchingStyleAttr = shouldValidateAttr(data, 'style') | ||
| ? validateStyleAttr(vnode, elm, data, renderer) | ||
| : true; | ||
| if (isFalse(hasMatchingAttrs && hasMatchingClass && hasMatchingStyleAttr)) { |
There was a problem hiding this comment.
We need to do class first, style second to match the ordering of non-static-optimized nodes. Otherwise our tests check for the ordering of console.errors and it's different between the two.
nolanlawson
commented
Oct 17, 2024
There was a problem hiding this comment.
This test was previously split into two. Now it has an if (process.env.DISABLE_STATIC_CONTENT_OPTIMIZATION) check instead.
nolanlawson
commented
Oct 17, 2024
wjhsf
approved these changes
Oct 18, 2024
Co-authored-by: Will Harney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #4586
DISABLE_STATIC_CONTENT_OPTIMIZATION=1 yarn hydration:testlwc:spread={fake}hack to disable the static content optimizationclass/styleorder #4656)Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?