chore(scripts): use nx for (pre-)release #4445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
reviewed
Aug 7, 2024
| @@ -28,7 +28,8 @@ | |||
| "test:performance:best": "nx test:best @lwc/perf-benchmarks", | |||
| "test:performance:best:ci": "nx test:best:ci @lwc/perf-benchmarks", | |||
| "test:types": "nx test @lwc/integration-types", | |||
| "release:version": "./scripts/release/version.js" | |||
| "release:version": "nx release version", | |||
| "release:publish": "nx release publish --registry https://registry.npmjs.org" | |||
nolanlawson
reviewed
Aug 7, 2024
| "@rollup/plugin-commonjs": "^26.0.1", | ||
| "@rollup/plugin-inject": "^5.0.5", | ||
| "@rollup/plugin-node-resolve": "^15.2.3", | ||
| "@rollup/plugin-replace": "^5.0.7", | ||
| "@rollup/plugin-typescript": "^11.1.6", | ||
| "@swc-node/register": "~1.9.1", | ||
| "@swc/core": "~1.5.7", | ||
| "@swc/helpers": "~0.5.11", |
There was a problem hiding this comment.
I find it bizarre that Nx wants these things, but 🤷
There was a problem hiding this comment.
When I ran nx release version it told me "hey you gotta run nx add @nx/js first", so I did. These are for TypeScript support, but it's unclear whether nx needs them or just thinks we might want them.
nolanlawson
reviewed
Aug 7, 2024
| @@ -39,11 +40,15 @@ | |||
| "@eslint/js": "^9.8.0", | |||
| "@lwc/eslint-plugin-lwc-internal": "link:./scripts/eslint-plugin", | |||
| "@lwc/test-utils-lwc-internals": "link:./scripts/test-utils", | |||
| "@nx/js": "19.5.6", | |||
There was a problem hiding this comment.
Tildes vs carets vs bare version numbers are all over the place in this repo, but it doesn't really matter since it's devDeps and so the lockfile is the truth.
nolanlawson
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We have a custom script to bump package versions that we don't actually need because
nxcan do it.In our internal release doc, we have a short bash script to publish canary releases that we don't actually need because
nxcan do it.This PR lets
nxdo it.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item