Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(scripts): use nx for (pre-)release #4445

Merged
merged 3 commits into from
Aug 8, 2024
Merged

chore(scripts): use nx for (pre-)release #4445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06a22de
chore(release): add @nx/js to enable nx release
wjhsf Aug 7, 2024
8675622
chore(release): use nx instead of bespoke script
wjhsf Aug 7, 2024
e8187ba
chore(release): add helper script for publish
wjhsf Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
"test:performance:best": "nx test:best @lwc/perf-benchmarks",
"test:performance:best:ci": "nx test:best:ci @lwc/perf-benchmarks",
"test:types": "nx test @lwc/integration-types",
"release:version": "./scripts/release/version.js"
"release:version": "nx release version",
"release:publish": "nx release publish --registry https://registry.npmjs.org"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

},
"//": {
"prettier": "v3 requires ESM, and we use prettier in our Jest tests. Jest does not support ESM yet."
Expand All @@ -39,11 +40,15 @@
"@eslint/js": "^9.8.0",
"@lwc/eslint-plugin-lwc-internal": "link:./scripts/eslint-plugin",
"@lwc/test-utils-lwc-internals": "link:./scripts/test-utils",
"@nx/js": "19.5.6",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tildes vs carets vs bare version numbers are all over the place in this repo, but it doesn't really matter since it's devDeps and so the lockfile is the truth.

"@rollup/plugin-commonjs": "^26.0.1",
"@rollup/plugin-inject": "^5.0.5",
"@rollup/plugin-node-resolve": "^15.2.3",
"@rollup/plugin-replace": "^5.0.7",
"@rollup/plugin-typescript": "^11.1.6",
"@swc-node/register": "~1.9.1",
"@swc/core": "~1.5.7",
"@swc/helpers": "~0.5.11",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it bizarre that Nx wants these things, but 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran nx release version it told me "hey you gotta run nx add @nx/js first", so I did. These are for TypeScript support, but it's unclear whether nx needs them or just thinks we might want them.

"@types/babel__core": "^7.20.5",
"@types/node": "^22.1.0",
"@types/prettier": "^2.7.3",
Expand Down Expand Up @@ -98,5 +103,6 @@
},
"http-cache-semantics": "4.1.1",
"semver": "7.6.0"
}
},
"dependencies": {}
}
12 changes: 0 additions & 12 deletions scripts/release/README.md
View file
Open in desktop

This file was deleted.

101 changes: 0 additions & 101 deletions scripts/release/version.js
View file
Open in desktop

This file was deleted.

Loading
Loading