Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup HTTP to HTTPS redirect #217

Closed
nschonni opened this issue Jun 26, 2018 · 6 comments
Closed

Setup HTTP to HTTPS redirect #217

nschonni opened this issue Jun 26, 2018 · 6 comments

Comments

@nschonni
Copy link
Contributor

Ugh, after adding the Code of Conduct to most of the repos in the org, it was pointed out the URL was using HTTP. I'll probably go back and change that, but I figured I'd open something here to see if we can get a redirect to HTTPS on the site.

@asottile
Copy link
Member

also let me know and I can do a mass find replace ala all-repos to update urls :)

@nex3 nex3 mentioned this issue Feb 26, 2019
@jina jina closed this as completed in #291 Mar 4, 2019
@asottile
Copy link
Member

asottile commented Mar 4, 2019

@nschonni @jina let me know and I'll run this command to make PRs replace all the http links with https:

all-repos-sed 's|http://sass-lang.com/|https://sass-lang.com/|g' '*' \
    --commit-msg "$(echo -e 'https-ify sass-lang.com urls\n\nSee https:/sass/sass-site/issues/217')" \
    --dry-run \
    --branch-name httpsify \
    --repos $(all-repos-grep --repos -C all-repos-sass.json http://sass-lang.com)

@jina
Copy link
Member

jina commented Mar 4, 2019

@asottile did @nex3’s PR that just got merged not fix it? #291

@asottile
Copy link
Member

asottile commented Mar 4, 2019

oh it did, but there's lots of links across the sass org projects that link to http :) -- I can fix 'em all at once:

(For example here's the dry-run against one repo)

$ all-repos-sed 's|http://sass-lang.com/|https://sass-lang.com/|g' '*' --commit-msg "$(echo -e 'https-ify sass-lang.com urls\n\nSee https:/sass/sass-site/issues/217')" --dry-run --branch-name httpsify --repos repos-sass/sass/sassc-rails/
***repos-sass/sass/sassc-rails/
$ git clone --quiet repos-sass/sass/sassc-rails/ /tmp/tmp9rdsf_q4
$ git remote set-url origin [email protected]:sass/sassc-rails
$ git fetch --prune --quiet
$ git checkout --quiet origin/HEAD -b all-repos_autofix_httpsify
$ sed -i 's|http://sass-lang.com/|https://sass-lang.com/|g' .gitignore .travis.yml CODE_OF_CONDUCT.md Gemfile LICENSE.txt README.md Rakefile gemfiles/rails_4_2.gemfile gemfiles/rails_5_2.gemfile gemfiles/sprockets-rails_2_3.gemfile gemfiles/sprockets-rails_3_0.gemfile gemfiles/sprockets_3_0.gemfile gemfiles/sprockets_4_0.gemfile lib/rails/generators/sass/assets/assets_generator.rb lib/rails/generators/sass/assets/templates/stylesheet.sass lib/rails/generators/sass/scaffold/scaffold_generator.rb lib/rails/generators/sass_scaffold.rb lib/rails/generators/scss/assets/assets_generator.rb lib/rails/generators/scss/assets/templates/stylesheet.scss lib/rails/generators/scss/scaffold/scaffold_generator.rb lib/sassc-rails.rb lib/sassc/rails.rb lib/sassc/rails/compressor.rb lib/sassc/rails/functions.rb lib/sassc/rails/importer.rb lib/sassc/rails/railtie.rb lib/sassc/rails/template.rb lib/sassc/rails/version.rb sassc-rails.gemspec test/dummy/app/assets/config/manifest.js test/dummy/app/assets/fonts/fake-font.ttf test/dummy/app/assets/images/.keep test/dummy/app/assets/images/1x1.png test/dummy/app/assets/images/rails.png test/dummy/app/assets/stylesheets/_top_level_partial.scss test/dummy/app/assets/stylesheets/application.scss test/dummy/app/assets/stylesheets/css_application.css test/dummy/app/assets/stylesheets/css_erb_handler.css.erb test/dummy/app/assets/stylesheets/css_sass_erb_handler.sass.erb test/dummy/app/assets/stylesheets/css_sass_handler.css.sass test/dummy/app/assets/stylesheets/css_scss_erb_handler.scss.erb test/dummy/app/assets/stylesheets/css_scss_handler.css.scss test/dummy/app/assets/stylesheets/erb_render_with_context.css.erb test/dummy/app/assets/stylesheets/glob_test.scss test/dummy/app/assets/stylesheets/globbed/globbed.scss test/dummy/app/assets/stylesheets/globbed/nested/nested_glob.scss test/dummy/app/assets/stylesheets/helpers_test.scss test/dummy/app/assets/stylesheets/imports_test.scss test/dummy/app/assets/stylesheets/in_load_paths/partial_in_load_paths.scss test/dummy/app/assets/stylesheets/partials/_css_sass_import.sass test/dummy/app/assets/stylesheets/partials/_explicit_extension_import.foo test/dummy/app/assets/stylesheets/partials/_sass_import.sass test/dummy/app/assets/stylesheets/partials/_scss_import.scss test/dummy/app/assets/stylesheets/partials/_without_css_ext.scss test/dummy/app/assets/stylesheets/partials/subfolder/_relative_sass.sass test/dummy/app/assets/stylesheets/partials/subfolder/_relative_scss.scss test/dummy/app/assets/stylesheets/partials/subfolder/relative_not_a_partial.scss test/dummy/app/assets/stylesheets/sass_erb_handler.sass.erb test/dummy/app/assets/stylesheets/scss_erb_handler.scss.erb test/dummy/app/assets/stylesheets/special_characters.scss test/dummy/app/assets/stylesheets/subfolder/_defaults.scss test/dummy/app/assets/stylesheets/subfolder/another_plain.css test/dummy/app/assets/stylesheets/subfolder/plain.css test/dummy/app/assets/stylesheets/subfolder/second_level.scss test/dummy/app/assets/stylesheets/syntax_error.scss test/sassc_rails_test.rb test/test_helper.rb
$ git diff origin/HEAD --exit-code
diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md
index dfc4c84..c4164af 100644
--- a/CODE_OF_CONDUCT.md
+++ b/CODE_OF_CONDUCT.md
@@ -7,4 +7,4 @@ fair place to play.
 
 [The full community guidelines can be found on the Sass website.][link]
 
-[link]: http://sass-lang.com/community-guidelines
+[link]: https://sass-lang.com/community-guidelines
diff --git a/lib/rails/generators/sass/assets/templates/stylesheet.sass b/lib/rails/generators/sass/assets/templates/stylesheet.sass
index 25a5df9..4c7ead2 100644
--- a/lib/rails/generators/sass/assets/templates/stylesheet.sass
+++ b/lib/rails/generators/sass/assets/templates/stylesheet.sass
@@ -1,3 +1,3 @@
 // Place all the styles related to the <%= name %> controller here.
 // They will automatically be included in application.css.
-// You can use Sass here: http://sass-lang.com/
+// You can use Sass here: https://sass-lang.com/
diff --git a/lib/rails/generators/scss/assets/templates/stylesheet.scss b/lib/rails/generators/scss/assets/templates/stylesheet.scss
index 2e92369..84d2cf7 100644
--- a/lib/rails/generators/scss/assets/templates/stylesheet.scss
+++ b/lib/rails/generators/scss/assets/templates/stylesheet.scss
@@ -1,3 +1,3 @@
 // Place all the styles related to the <%= name %> controller here.
 // They will automatically be included in application.css.
-// You can use Sass (SCSS) here: http://sass-lang.com/
+// You can use Sass (SCSS) here: https://sass-lang.com/
$ git commit --quiet -a -m 'https-ify sass-lang.com urls

See https:/sass/sass-site/issues/217

Committed via https:/asottile/all-repos'

@jina
Copy link
Member

jina commented Mar 4, 2019

gotcha. submit a PR! :)

@asottile
Copy link
Member

asottile commented Mar 4, 2019

PRs made! (they all link here)

xzyfer pushed a commit to sass/node-sass that referenced this issue Mar 5, 2019
* https-ify sass-lang.com urls

See sass/sass-site#217

Committed via https:/asottile/all-repos

* Revert changes to vendored libsass
nex3 pushed a commit to sass/dart-sass that referenced this issue Mar 5, 2019
nex3 pushed a commit to sass/homebrew-sass that referenced this issue Mar 5, 2019
nex3 pushed a commit to sass/linter that referenced this issue Mar 5, 2019
nex3 pushed a commit to sass/embedded-protocol that referenced this issue Mar 5, 2019
nex3 pushed a commit to sass/ruby-sass that referenced this issue Mar 5, 2019
nex3 pushed a commit to sass/sass-spec that referenced this issue Mar 5, 2019
jathak pushed a commit to sass/migrator that referenced this issue Mar 8, 2019
xzyfer pushed a commit to sass/libsass that referenced this issue Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants