Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https-ify sass-lang.com urls #247

Merged
merged 2 commits into from
Mar 5, 2019
Merged

https-ify sass-lang.com urls #247

merged 2 commits into from
Mar 5, 2019

Conversation

asottile
Copy link
Member

@asottile asottile commented Mar 4, 2019

Copy link
Contributor

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile
Copy link
Member Author

asottile commented Mar 4, 2019

weird! how did it miss that :S, yeah let me get that too

@asottile
Copy link
Member Author

asottile commented Mar 4, 2019

oh! because I included the trailing slash 🤦‍♂️

@am11
Copy link
Contributor

am11 commented Mar 4, 2019

git grep sass-lang\.com 😸

@asottile
Copy link
Member Author

asottile commented Mar 4, 2019

yeah my bug was the sed command I used: 's|http://sass-lang.com/|https://sass-lang.com/|g'

shouldn't have included the slash there 😭

@asottile
Copy link
Member Author

asottile commented Mar 4, 2019

Fortunately it's easy for me to find the ones I missed with the same tooling:

$ all-repos-grep -C all-repos-sass.json http://sass-lang.com | grep -v 'http://sass-lang.com/'
repos-sass/sass/libsass:Readme.md:For more information about Sass itself, please visit http://sass-lang.com
repos-sass/sass/libsass.com:index.html:        <p><a href="http://sass-lang.com">Sass</a> is a pre-processing language for CSS. It allows you to write cleaner stylesheets and makes collaboration on your CSS a breeze. There's a ton of information on Sass out there, so we won't repeat it all here. Just make sure to check out <a href="http://sass-lang.com" target="_blank">the Sass site</a> for tutorials and examples.</p>
repos-sass/sass/node-sass:src/libsass/Readme.md:For more information about Sass itself, please visit http://sass-lang.com
repos-sass/sass/ruby-sass:doc-src/SASS_REFERENCE.md:such as `"Lucida Grande"` or `'http://sass-lang.com'`,
repos-sass/sass/ruby-sass:test/sass/scss/css_test.rb:  f: url(http://sass-lang.com);
repos-sass/sass/sass:doc-src/SASS_REFERENCE.md:such as `"Lucida Grande"` or `'http://sass-lang.com'`,
repos-sass/sass/sass:test/sass/scss/css_test.rb:  f: url(http://sass-lang.com);
repos-sass/sass/sassc:Readme.md:For more information about Sass itself, please visit http://sass-lang.com

@am11 am11 merged commit 2265348 into sass:master Mar 5, 2019
@asottile asottile deleted the all-repos_autofix_httpsify branch March 5, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants