Skip to content

try fix colliding embebedded-websocket feature with dep: syntax #83

try fix colliding embebedded-websocket feature with dep: syntax

try fix colliding embebedded-websocket feature with dep: syntax #83

Triggered via push January 28, 2024 13:18
Status Success
Total duration 55s
Artifacts

quality_test.yml

on: push
clippy_check
45s
clippy_check
Fit to window
Zoom out
Zoom in

Annotations

14 warnings
useless use of `vec!`: src/wallet/mod.rs#L91
warning: useless use of `vec!` --> src/wallet/mod.rs:91:27 | 91 | let string_list = vec![ | ___________________________^ 92 | | format!("public_key: {}", self.public_key), 93 | | format!("private_key: {}", "-HIDDEN-"), 94 | | format!("classic_address: {}", self.classic_address), 95 | | ]; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[warn(clippy::useless_vec)]` on by default help: you can use an array directly | 91 ~ let string_list = [format!("public_key: {}", self.public_key), 92 + format!("private_key: {}", "-HIDDEN-"), 93 ~ format!("classic_address: {}", self.classic_address)]; |
the `Err`-variant returned from this function is very large: src/models/requests/ledger_entry.rs#L221
warning: the `Err`-variant returned from this function is very large --> src/models/requests/ledger_entry.rs:221:35 | 221 | fn _get_field_error(&self) -> Result<(), XRPLLedgerEntryException>; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ::: src/models/requests/exceptions.rs:43:5 | 43 | / DefineExactlyOneOf { 44 | | field1: Cow<'a, str>, 45 | | field2: Cow<'a, str>, 46 | | field3: Cow<'a, str>, ... | 54 | | resource: Cow<'a, str>, 55 | | }, | |_____- the largest variant contains at least 264 bytes | = help: try reducing the size of `models::requests::exceptions::XRPLLedgerEntryException<'_>`, for example by boxing large elements or replacing it with `Box<models::requests::exceptions::XRPLLedgerEntryException<'_>>` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err = note: `#[warn(clippy::result_large_err)]` on by default
this function has too many arguments (8/7): src/models/ledger/objects/signer_list.rs#L98
warning: this function has too many arguments (8/7) --> src/models/ledger/objects/signer_list.rs:98:5 | 98 | / pub fn new( 99 | | flags: Vec<SignerListFlag>, 100 | | index: Cow<'a, str>, 101 | | owner_node: Cow<'a, str>, ... | 106 | | signer_quorum: u32, 107 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (13/7): src/models/ledger/objects/ripple_state.rs#L114
warning: this function has too many arguments (13/7) --> src/models/ledger/objects/ripple_state.rs:114:5 | 114 | / pub fn new( 115 | | flags: Vec<RippleStateFlag>, 116 | | index: Cow<'a, str>, 117 | | balance: Amount<'a>, ... | 127 | | low_quality_out: Option<u32>, 128 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (15/7): src/models/ledger/objects/pay_channel.rs#L96
warning: this function has too many arguments (15/7) --> src/models/ledger/objects/pay_channel.rs:96:5 | 96 | / pub fn new( 97 | | index: Cow<'a, str>, 98 | | account: Cow<'a, str>, 99 | | amount: Amount<'a>, ... | 111 | | source_tag: Option<u32>, 112 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (12/7): src/models/ledger/objects/offer.rs#L95
warning: this function has too many arguments (12/7) --> src/models/ledger/objects/offer.rs:95:5 | 95 | / pub fn new( 96 | | flags: Vec<OfferFlag>, 97 | | index: Cow<'a, str>, 98 | | account: Cow<'a, str>, ... | 107 | | expiration: Option<u32>, 108 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (11/7): src/models/ledger/objects/nftoken_offer.rs#L96
warning: this function has too many arguments (11/7) --> src/models/ledger/objects/nftoken_offer.rs:96:5 | 96 | / pub fn new( 97 | | flags: Vec<NFTokenOfferFlag>, 98 | | index: Cow<'a, str>, 99 | | amount: Amount<'a>, ... | 107 | | owner_node: Option<Cow<'a, str>>, 108 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (13/7): src/models/ledger/objects/escrow.rs#L100
warning: this function has too many arguments (13/7) --> src/models/ledger/objects/escrow.rs:100:5 | 100 | / pub fn new( 101 | | index: Cow<'a, str>, 102 | | account: Cow<'a, str>, 103 | | amount: Amount<'a>, ... | 113 | | source_tag: Option<u32>, 114 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (11/7): src/models/ledger/objects/directory_node.rs#L87
warning: this function has too many arguments (11/7) --> src/models/ledger/objects/directory_node.rs:87:5 | 87 | / pub fn new( 88 | | index: Cow<'a, str>, 89 | | indexes: Vec<Cow<'a, str>>, 90 | | root_index: Cow<'a, str>, ... | 98 | | taker_pays_issuer: Option<Cow<'a, str>>, 99 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (13/7): src/models/ledger/objects/check.rs#L85
warning: this function has too many arguments (13/7) --> src/models/ledger/objects/check.rs:85:5 | 85 | / pub fn new( 86 | | index: Cow<'a, str>, 87 | | account: Cow<'a, str>, 88 | | destination: Cow<'a, str>, ... | 98 | | source_tag: Option<u32>, 99 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): src/models/ledger/objects/amm.rs#L107
warning: this function has too many arguments (8/7) --> src/models/ledger/objects/amm.rs:107:5 | 107 | / pub fn new( 108 | | index: Cow<'a, str>, 109 | | amm_account: Cow<'a, str>, 110 | | asset: Currency<'a>, ... | 115 | | vote_slots: Option<Vec<VoteEntry>>, 116 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (21/7): src/models/ledger/objects/account_root.rs#L152
warning: this function has too many arguments (21/7) --> src/models/ledger/objects/account_root.rs:152:5 | 152 | / pub fn new( 153 | | flags: Vec<AccountRootFlag>, 154 | | index: Cow<'a, str>, 155 | | account: Cow<'a, str>, ... | 173 | | wallet_size: Option<u32>, 174 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/