Skip to content

try fix colliding embebedded-websocket feature with dep: syntax #83

try fix colliding embebedded-websocket feature with dep: syntax

try fix colliding embebedded-websocket feature with dep: syntax #83

GitHub Actions / clippy succeeded Jan 28, 2024 in 0s

clippy

12 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 12
Note 0
Help 0

Versions

  • rustc 1.77.0-nightly (6b4f1c5e7 2024-01-27)
  • cargo 1.77.0-nightly (7bb7b5395 2024-01-20)
  • clippy 0.1.77 (6b4f1c5 2024-01-27)

Annotations

Check warning on line 95 in src/wallet/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless use of `vec!`

warning: useless use of `vec!`
  --> src/wallet/mod.rs:91:27
   |
91 |           let string_list = vec![
   |  ___________________________^
92 | |             format!("public_key: {}", self.public_key),
93 | |             format!("private_key: {}", "-HIDDEN-"),
94 | |             format!("classic_address: {}", self.classic_address),
95 | |         ];
   | |_________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
   = note: `#[warn(clippy::useless_vec)]` on by default
help: you can use an array directly
   |
91 ~         let string_list = [format!("public_key: {}", self.public_key),
92 +             format!("private_key: {}", "-HIDDEN-"),
93 ~             format!("classic_address: {}", self.classic_address)];
   |

Check warning on line 221 in src/models/requests/ledger_entry.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the `Err`-variant returned from this function is very large

warning: the `Err`-variant returned from this function is very large
   --> src/models/requests/ledger_entry.rs:221:35
    |
221 |       fn _get_field_error(&self) -> Result<(), XRPLLedgerEntryException>;
    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
   ::: src/models/requests/exceptions.rs:43:5
    |
43  | /     DefineExactlyOneOf {
44  | |         field1: Cow<'a, str>,
45  | |         field2: Cow<'a, str>,
46  | |         field3: Cow<'a, str>,
...   |
54  | |         resource: Cow<'a, str>,
55  | |     },
    | |_____- the largest variant contains at least 264 bytes
    |
    = help: try reducing the size of `models::requests::exceptions::XRPLLedgerEntryException<'_>`, for example by boxing large elements or replacing it with `Box<models::requests::exceptions::XRPLLedgerEntryException<'_>>`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
    = note: `#[warn(clippy::result_large_err)]` on by default

Check warning on line 107 in src/models/ledger/objects/signer_list.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
   --> src/models/ledger/objects/signer_list.rs:98:5
    |
98  | /     pub fn new(
99  | |         flags: Vec<SignerListFlag>,
100 | |         index: Cow<'a, str>,
101 | |         owner_node: Cow<'a, str>,
...   |
106 | |         signer_quorum: u32,
107 | |     ) -> Self {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 128 in src/models/ledger/objects/ripple_state.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (13/7)

warning: this function has too many arguments (13/7)
   --> src/models/ledger/objects/ripple_state.rs:114:5
    |
114 | /     pub fn new(
115 | |         flags: Vec<RippleStateFlag>,
116 | |         index: Cow<'a, str>,
117 | |         balance: Amount<'a>,
...   |
127 | |         low_quality_out: Option<u32>,
128 | |     ) -> Self {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 112 in src/models/ledger/objects/pay_channel.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (15/7)

warning: this function has too many arguments (15/7)
   --> src/models/ledger/objects/pay_channel.rs:96:5
    |
96  | /     pub fn new(
97  | |         index: Cow<'a, str>,
98  | |         account: Cow<'a, str>,
99  | |         amount: Amount<'a>,
...   |
111 | |         source_tag: Option<u32>,
112 | |     ) -> Self {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 108 in src/models/ledger/objects/offer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (12/7)

warning: this function has too many arguments (12/7)
   --> src/models/ledger/objects/offer.rs:95:5
    |
95  | /     pub fn new(
96  | |         flags: Vec<OfferFlag>,
97  | |         index: Cow<'a, str>,
98  | |         account: Cow<'a, str>,
...   |
107 | |         expiration: Option<u32>,
108 | |     ) -> Self {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 108 in src/models/ledger/objects/nftoken_offer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (11/7)

warning: this function has too many arguments (11/7)
   --> src/models/ledger/objects/nftoken_offer.rs:96:5
    |
96  | /     pub fn new(
97  | |         flags: Vec<NFTokenOfferFlag>,
98  | |         index: Cow<'a, str>,
99  | |         amount: Amount<'a>,
...   |
107 | |         owner_node: Option<Cow<'a, str>>,
108 | |     ) -> Self {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 114 in src/models/ledger/objects/escrow.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (13/7)

warning: this function has too many arguments (13/7)
   --> src/models/ledger/objects/escrow.rs:100:5
    |
100 | /     pub fn new(
101 | |         index: Cow<'a, str>,
102 | |         account: Cow<'a, str>,
103 | |         amount: Amount<'a>,
...   |
113 | |         source_tag: Option<u32>,
114 | |     ) -> Self {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 99 in src/models/ledger/objects/directory_node.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (11/7)

warning: this function has too many arguments (11/7)
  --> src/models/ledger/objects/directory_node.rs:87:5
   |
87 | /     pub fn new(
88 | |         index: Cow<'a, str>,
89 | |         indexes: Vec<Cow<'a, str>>,
90 | |         root_index: Cow<'a, str>,
...  |
98 | |         taker_pays_issuer: Option<Cow<'a, str>>,
99 | |     ) -> Self {
   | |_____________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 99 in src/models/ledger/objects/check.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (13/7)

warning: this function has too many arguments (13/7)
  --> src/models/ledger/objects/check.rs:85:5
   |
85 | /     pub fn new(
86 | |         index: Cow<'a, str>,
87 | |         account: Cow<'a, str>,
88 | |         destination: Cow<'a, str>,
...  |
98 | |         source_tag: Option<u32>,
99 | |     ) -> Self {
   | |_____________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 116 in src/models/ledger/objects/amm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
   --> src/models/ledger/objects/amm.rs:107:5
    |
107 | /     pub fn new(
108 | |         index: Cow<'a, str>,
109 | |         amm_account: Cow<'a, str>,
110 | |         asset: Currency<'a>,
...   |
115 | |         vote_slots: Option<Vec<VoteEntry>>,
116 | |     ) -> Self {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 174 in src/models/ledger/objects/account_root.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (21/7)

warning: this function has too many arguments (21/7)
   --> src/models/ledger/objects/account_root.rs:152:5
    |
152 | /     pub fn new(
153 | |         flags: Vec<AccountRootFlag>,
154 | |         index: Cow<'a, str>,
155 | |         account: Cow<'a, str>,
...   |
173 | |         wallet_size: Option<u32>,
174 | |     ) -> Self {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default