Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bug=impureThrow #100

Closed
int-index opened this issue Dec 19, 2017 · 3 comments
Closed

Add bug=impureThrow #100

int-index opened this issue Dec 19, 2017 · 3 comments
Assignees
@vrom911
Labels
feature request good first issue help wanted

Comments

@int-index
Copy link
Member

Define bug roughly as follows:

import Control.Exception.Safe (impureThrow)

data Bug = Bug SomeException CallStack

instance Exception Bug

bug :: (HasCallStack, Exception e) => e -> a
bug e = impureThrow $ Bug (toException e) ?callStack
@int-index int-index mentioned this issue Dec 19, 2017
Merged
@chshersh
Copy link
Contributor

@int-index Could you please explain why we need to store HasCallStack explicitly in Bug constructor?

@int-index
Copy link
Member Author

Because we want to use it in displayException for Bug.

@int-index
Copy link
Member Author

That is how it is done for ErrorCall.

vrom911 added a commit that referenced this issue Dec 21, 2017
@vrom911
[#100] Add bug
6ae961f
@vrom911 vrom911 mentioned this issue Dec 21, 2017
Merged
vrom911 added a commit that referenced this issue Dec 22, 2017
@vrom911
[#100] Add implementation of displayException for Bug
4dda527
vrom911 added a commit that referenced this issue Dec 22, 2017
@vrom911
Merge pull request #103 from serokell/vrom911/100-bug
ed9c424 
[#100] Add bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrom911 vrom911

Labels
feature request good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@int-index @chshersh @vrom911