[#100] Add bug #103
Merged
[#100] Add bug #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int-index
requested changes
Dec 21, 2017
src/Universum/Exception.hs
Outdated
| -- | Generate a pure value which, when forced, will synchronously | ||
| -- throw the exception wrapped into 'Bug' data type. | ||
| bug :: (HasCallStack, Exception e) => e -> a | ||
| bug e = Safe.impureThrow (Bug (Safe.toException e) ?callStack) |
There was a problem hiding this comment.
I found this note in base docs:
Instead of ?callStack, we should use the callStack function from GHC.Stack.
There was a problem hiding this comment.
Then the ImplicitParams extension can be removed.
src/Universum/Exception.hs
Outdated
| data Bug = Bug SomeException CallStack | ||
| deriving (Show) | ||
|
|
||
| instance Exception Bug |
There was a problem hiding this comment.
Let's have a proper displayException implementation here. We should use the prettyCallStack function from GHC.Stack to render the call stack, displayException to render the stored SomeException, and concatenate the two using with "\n" in between (SomeException comes first, then "\n", then pretty-printed CallStack).
This would match the behavior of error.
int-index
approved these changes
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #100