-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shipwright uses API group *.build.dev #563
Milestone
Comments
Agreed, Jason! |
+1 ! |
I don't believe migration using webhooks is possible. 😞 There is a webhook conversion mechanism that converts between versions of the same Kind, but I don't believe it's possible to change the apiVersion. Since migration will probably require a breaking change for users, I think we should do it sooner while there are relatively fewer users to break. This will be much more painful in 6 months, a year, etc. |
This was referenced Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Shipwright's CRD types are defined in the API group
build.build.dev
(source). Kubernetes' API conventions recommends using a domain that your team owns:Presumably this is to prevent the case where someone acquires the domain later, which can cause confusion at best, and possibly even security concerns down the line. edit: build.dev is available for purchase, coincidentally, but the price tag is a bit high at $64,999... 💰
It might be a good idea to switch this over time to a domain owned by the team, e.g.,
build.shipwright.io
. Since Shipwright is still in early alpha, it'd probably be better to do this soon before you get more usage, which would make changes harder to make in the future.The text was updated successfully, but these errors were encountered: