-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename build.dev -> shipwright.io #609
Rename build.dev -> shipwright.io #609
Conversation
👍 A quick question, how about the previous proposal doc, like: https:/shipwright-io/build/blob/master/docs/proposals/buildstrategy-steps-resources.md Do we need to sync too or just keep the original API name? |
I explicitly didn't want to update proposal docs, because I don't own them, and the historical context might be meaningful (and because, being non-user-facing docs, they're not urgently necessary to update). If you see a proposal that you think should be updated after this change please feel free. |
0ef41f1
to
4df4639
Compare
Good day @imjasonh , How about this PR, or do you need any help here? :) |
I believe this change works, believe it or not, but I'd love another pair of eyes on the changes to make sure I got everything. Other than that, test flakes and (limited time to debug them) is currently blocking the merge. Any help there would be great, not just for this change, but also for #600 #607 etc |
Changes look fine to me. I think it's fine to keep the proposal docs as is for now. From your perspective @zhangtbj @qu1queee @SaschaSchwarze0 when would you want to this change to get merged and released? |
Cool thanks @imjasonh ! I will also take some time on these PRs. Will let you know once I have any update. |
Hi @sbose78 , It also looks for me, and we will help to solve the test failure first. For us, it is better to get merged soon, we need time to do the migration work and UX integration work, it will take some time after this PR is accepted :) |
It looks like we have a real issue going on with the v1.20 test. The Conditions array seems to have duplicates:
|
@imjasonh pls rebase this one on top of master, it will help the tests while we removed the multiple k8s versions test. |
This seems to have helped! 👍 I am a bit nervous that we may have found a genuine bug with v1.20 though... 🤔 |
Hi, Does anyone know if this PR was just ran the tests on |
This renames references to the build.dev API group, replacing them with shipwright.io. This change updates code and docs, but doesn't modify anything in docs/proposals/. This constitutes a breaking change for existing users, who will need to modify their Builds/BuildStrategies/BuildRuns to use the new API group. No other changes are expected to be needed. When upgrading, users should delete the old CRD types before installing the new ones, to avoid confusion (kubectl delete -f deploy/crds/).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This renames references to the
build.dev
API group, replacing them withshipwright.io
. This change updates code and docs, but doesn't modify anything indocs/proposals/
.This constitutes a breaking change for existing users, who will need to modify their Builds/BuildStrategies/BuildRuns to use the new API group. No other changes are expected to be needed. When upgrading, users should delete the old CRD types before installing the new ones, to avoid confusion (
kubectl delete -f deploy/crds/
).Fixes #563
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes