Nightly releases failing since 05/18

[imjasonh]

e.g., https:/shipwright-io/build/runs/2617025110 from 5/19

Relevant logs:

2021/05/19 05:23:53 Publishing quay.io/shipwright/shipwright-build-controller:nightly-2021-05-19-1621401573
Error: error processing import paths in "deploy/500-controller.yaml": error resolving image references: HEAD https://quay.io/v2/shipwright/shipwright-build-controller/manifests/sha256:5a082fe25f6427efad95ca2c9d1c84ddec9236a9d4309c4d872e4b1c586ad5a5: unexpected status code 401 Unauthorized (HEAD responses have no body, use GET for details)

It seems possibly related to #770 (cc @SaschaSchwarze0) which renamed ./cmd/manager to ./cmd/shipwright-build-controller, and the image it builds from quay.io/shipwright/shipwright-operator to quay.io/shipwright/shipwright-build-controller (which is more correct thank you 🙏 )

I think someone has to manually create the quay.io/shipwright/shipwright-build-controller repository in Quay to be able to push manifests there. @adambkaplan does that sound right?

[SaschaSchwarze0]

Arg, damn, we forgot to check that. @qu1queee can also help with that as he recently added the base-git and git repositories there.

[qu1queee]

Updates from my side:

• [1] The https://quay.io/repository/shipwright/shipwright-build-controller repository already existed, but it was private.
• [2] The https://quay.io/repository/shipwright/shipwright-build-controller repository was missing the permissions to the bots ( we have one for github action + one for travis )
• [3] The repository is now public, and have the required bots in place, but nightly still not working.

I will try more things now, if I fail, I will need to summon Adam :)

[qu1queee]

Ok, so its fixed, see https:/shipwright-io/build/actions/runs/885321531.

The problem was that we were missing [1] and [2], and the reason why it was not working after that, is because the bots required "Write" permissions, I add only "Read".

@adambkaplan fyi

@imjasonh thanks for finding this.