-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of Tekton resources #770
Remove usage of Tekton resources #770
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c121440
to
06aa6c9
Compare
59b9f98
to
a302857
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not finished the full PR yet. We were able to check on the CI parts, publishing and integration tests. However, there are already things I would like to start a discussion.
samples/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3-heroku_cr.yaml
Outdated
Show resolved
Hide resolved
samples/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3-heroku_cr.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some comments on my first review. I still need to understand the override on the previous implementation @otaviof had for spec.sources, and then all changes when generating the Task/TaskRun, plus strategy renames. So pls expect 2 more reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next round of request for changes. Looks good in general, nice work!
samples/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3-heroku_namespaced_cr.yaml
Outdated
Show resolved
Hide resolved
a302857
to
10122e8
Compare
10122e8
to
d8194a7
Compare
d8194a7
to
f9675fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Related to Remove usage of Tekton resources #696.
Reviewers can go through the changes by commit:
GIT_IMAGE
environment variable, this is set in the Makefile in commit 7. @qu1queee please do not forget to create the git repository in quay as discussed, so that the image can be pushed by the build.chown
in prepare steps is necessary for non-root build strategies. Remaining is thechown
for the Tekton home directory that we will get rid of once we also move away from the service account and creds-init for the output image credential.shp-
prefix there.Submitter Checklist
Release Notes