Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 #155

Merged
merged 1 commit into from
Oct 18, 2023
Merged

v2.0.0 #155

merged 1 commit into from
Oct 18, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Sep 25, 2023

@sehz
Copy link

sehz commented Sep 25, 2023

Glad to see async-io is well maintained!

@zeenix
Copy link
Member

zeenix commented Sep 26, 2023

  • Breaking: Async::get_mut(), Async::read_with_mut() and Async::write_with_mut() are now unsafe. The underlying source is technically "borrowed" by the polling instance, so moving it out would be unsound. (Add smol-rs logo to docs #143)

I think there is a mistake here, #143 has nothing to do with the description here.

@notgull
Copy link
Member Author

notgull commented Sep 29, 2023

I think there is a mistake here, #143 has nothing to do with the description here.

Fixed!

Signed-off-by: John Nunley <[email protected]>
@zeenix
Copy link
Member

zeenix commented Oct 16, 2023

@notgull So this all ready to go? @taiki-e WDYT?

@zeenix zeenix requested a review from taiki-e October 16, 2023 15:32
@notgull notgull merged commit 7e89eec into master Oct 18, 2023
21 checks passed
@notgull notgull deleted the notgull/next branch October 18, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants