Add Async::new_nonblocking and avoid needless set_nonblocking calls #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
approved these changes
Oct 8, 2023
src/lib.rs
Outdated
|
|
||
| fn new_nonblocking(io: T) -> io::Result<Async<T>> { |
There was a problem hiding this comment.
Can we make this public to solve #132?
taiki-e
changed the title
connect() already sets socket to non-blocking mode.
taiki-e
force-pushed
the
taiki-e/nonblocking
branch
from
de07b6a
to
60bb9c5
Compare
notgull
reviewed
Oct 8, 2023
src/lib.rs
Outdated
Comment on lines
763
to
764
| /// On Unix systems, the handle must implement `AsRawFd`, while on Windows it must implement | ||
| /// `AsRawSocket`. |
There was a problem hiding this comment.
Nit: This is supposed to be AsFd and AsSocket.
taiki-e
force-pushed
the
taiki-e/nonblocking
branch
from
60bb9c5
to
6ae6575
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect() already sets socket to non-blocking mode.
The second comment exposes Async::new_nonblocking to resolve #132.