Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As7312 54x add sfp rest and fan policy #1464

Merged

Conversation

roylee123
Copy link
Collaborator

- What I did

  1. Add QSFP reset control.
  2. Validate fan control monitoring.

- How I did it
Add driver to provide reset device nodes and update sfputil.py for them.
Rectify thermal-policy script to fit as7312-54x's HW spec.

- How to verify it

  1. sfputil reset EthernetXX
  2. Open the cap and put a board to block air flow, it makes temperature rising.
    After any of sensors rose to more than 50dC, fans run at full speed.
    Remove blocking board to test temperature dropping.

- Description for the changelog

  1. change sfputil.py under device.
  2. thermal-control and driver are under submodule sonic-platform-modules-accton.


# For port 48~51 are QSFP, here presumed they're all split to 4 lanes.
def get_cage_num(self, port_num):
cage_num = port_num
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace tab with 4 spaces.


# For cage 0~23 and 48~51 are at cpld2, others are at cpld3.
def get_cpld_num(self, port_num):
cpld_i = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace tab with 4 spaces.

if (cage_num >= 52):
cpld_i = 2
cage_num = self.get_cage_num(port_num)
cpld_i = self.get_cpld_num(port_num)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace tab with 4 spaces.

path = "/sys/bus/i2c/devices/5-0062/module_reset_{0}"
port_ps = path.format(port_num+1)
cage_num = self.get_cage_num(port_num)
cpld_i = self.get_cpld_num(port_num)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace tab with 4 spaces.

Signed-off-by: roy_lee <[email protected]>
…to as7312_54x_add_sfp_rest_and_fan_policy

Signed-off-by: roy_lee <[email protected]>

Conflicts:
	platform/broadcom/sonic-platform-modules-accton
@lguohan lguohan merged commit 33252a4 into sonic-net:master Mar 14, 2018
@daall daall mentioned this pull request Oct 26, 2020
3 tasks
@ghost ghost mentioned this pull request Mar 24, 2021
4 tasks
lguohan pushed a commit that referenced this pull request Mar 27, 2021
* 1ee04fb (HEAD -> master, origin/master, origin/HEAD) Modified the tests to use mock functionality of get_child_port function under portconfig utility (#1464)
* 99d251f Enable PFCWD only on ports where PFC is enabled (#1508)
* eb7945f Warmboot script improvements - timeout exec, disable swss autorestart, remove trap (#1495)
* c7d4947 [show] Fix int status of LAGs, configured as Vlan members (#1478)

Signed-off-by: Maksym Belei <[email protected]>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
…on under portconfig utility (sonic-net#1464)

Modified the tests to use mock functionality of get_child_port function under portconfig utility. This will remove the dependency of port config utility in the sonic-buildimage and make the test case more robust specific to the DPB cli utility.

Signed-off-by: Sangita Maity <[email protected]>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
* 1ee04fb (HEAD -> master, origin/master, origin/HEAD) Modified the tests to use mock functionality of get_child_port function under portconfig utility (sonic-net#1464)
* 99d251f Enable PFCWD only on ports where PFC is enabled (sonic-net#1508)
* eb7945f Warmboot script improvements - timeout exec, disable swss autorestart, remove trap (sonic-net#1495)
* c7d4947 [show] Fix int status of LAGs, configured as Vlan members (sonic-net#1478)

Signed-off-by: Maksym Belei <[email protected]>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
* 1ee04fb (HEAD -> master, origin/master, origin/HEAD) Modified the tests to use mock functionality of get_child_port function under portconfig utility (sonic-net#1464)
* 99d251f Enable PFCWD only on ports where PFC is enabled (sonic-net#1508)
* eb7945f Warmboot script improvements - timeout exec, disable swss autorestart, remove trap (sonic-net#1495)
* c7d4947 [show] Fix int status of LAGs, configured as Vlan members (sonic-net#1478)

Signed-off-by: Maksym Belei <[email protected]>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants