Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation] Allow filtering by project in Find Spring Elements list #173

Closed
gayanper opened this issue Jan 4, 2019 · 8 comments
Closed
Milestone

Comments

@gayanper
Copy link
Contributor

gayanper commented Jan 4, 2019

The default implementation is to show spring elements in workspace or on current file. It would be really usefull if the elements can be filtered on the current project as well. One could easily filter the elements by their path using the current active editor's project name. This can be programmed to another cycle of CTRL+6 like workspace, project and current file. Or else one could program it to be able filter using a different keyword in the filter field. I personally prefer the option 1 since it make the user experience more straight forward.

@gayanper
Copy link
Contributor Author

gayanper commented Jan 4, 2019

This should be a eclipse only feature since other tools doesn't have a notion of multiple projects in a workspace.

gayanper added a commit to gayanper/sts4 that referenced this issue Jan 5, 2019
Add new provider which will filter symbols for the current selected
resource's project in GoTo Symbol dialog.
@gayanper
Copy link
Contributor Author

gayanper commented Jan 5, 2019

@martinlippert here is a PR which adds support for in project symbols for eclipse.

@gayanper
Copy link
Contributor Author

gayanper commented Jan 7, 2019

@martinlippert any feedback on this ?

@kdvolder
Copy link
Member

kdvolder commented Jan 7, 2019

This should be a eclipse only feature since other tools doesn't have a notion of multiple projects in a workspace.

That's not true. It isn't as obvious perhaps but vscode also has projects since vscode java support is basically a wrapper on Eclipse JDT (pakcaged as a language server).

@kdvolder
Copy link
Member

kdvolder commented Jan 7, 2019

FWIW: I like the idea of being able to filter symbol by current project.

@gayanper
Copy link
Contributor Author

gayanper commented Jan 7, 2019

That's not true. It isn't as obvious perhaps but vscode also has projects since vscode java support is basically a wrapper on Eclipse JDT (pakcaged as a language server).

Hmmm thats good to know. But since the language server api doesn't have support for project notion vscode implementation might look similar to this. May be someone who is really fluent in js development can take it up.

@gayanper
Copy link
Contributor Author

gayanper commented Jan 7, 2019

@kdevolder the PR is already there. You can give it a try 😊

@kdvolder
Copy link
Member

kdvolder commented Jan 7, 2019

@gayanper I see what you are saying now. Yes language server protocol doesn't have the concept of a 'project'. The closest thing would be a workspaceFolders but its really not the same as the 'projects' that jdt identifies.

So yeah, it seems hard to implement this functionality in vscode (more so because the UI isn't implemented by us, but is part of the vscode 'generic' language server client).

Anyhoo.... I still support having the project-based filter in our Eclipse 'goto symbol' ui, independent of whether or not we have something similar in vscode (or other clients).

martinlippert added a commit that referenced this issue Jan 9, 2019
Fix #173 : Add support for filtering project symbols
@martinlippert martinlippert added this to the 4.1.1.RELEASE milestone Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants