Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #173 : Add support for filtering project symbols #174

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

gayanper
Copy link
Contributor

@gayanper gayanper commented Jan 5, 2019

Add new provider which will filter symbols for the current selected
resource's project in GoTo Symbol dialog.

@pivotal-issuemaster
Copy link

@gayanper Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@gayanper Thank you for signing the Contributor License Agreement!

@gayanper
Copy link
Contributor Author

gayanper commented Jan 7, 2019

any feedback on this ? :)

@martinlippert
Copy link
Member

Looks good to me. The only missing piece is the copyright header in the new InProjectSymbolsProvider, please add and update the PR.

Add new provider which will filter symbols for the current selected
resource's project in GoTo Symbol dialog.
@gayanper
Copy link
Contributor Author

gayanper commented Jan 8, 2019

@martinlippert update the copyright header 👍

@martinlippert
Copy link
Member

great, maybe one more small fix? The Copyright header mentions 2017, should be 2019... :-)

@martinlippert martinlippert merged commit 9252f0a into spring-projects:master Jan 9, 2019
@martinlippert
Copy link
Member

Never mind, merged the PR and will do the fix for the copyright year myself. Many many thanks for the contribution, very much appreciated !!!

@gayanper
Copy link
Contributor Author

gayanper commented Jan 9, 2019

@martinlippert sorry i was planning to do it tonight after office :). You most welcome, sts4 is a great tool :)

@gayanper gayanper deleted the Bug173_InProject branch January 9, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants