Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and update existing extended base BLAS packages according to current project conventions #1152

Open
81 of 82 tasks
kgryte opened this issue Dec 4, 2023 · 9 comments · Fixed by #1773
Open
81 of 82 tasks
Labels
Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. Tracking Issue Tracking issue.

Comments

@kgryte
Copy link
Member

kgryte commented Dec 4, 2023

This should follow the same process as outlined in #788 but for @stdlib/blas/ext/base/*.

Packages needing updating:

  • @stdlib/blas/ext/base/dapx
  • @stdlib/blas/ext/base/dapxsum
  • @stdlib/blas/ext/base/dapxsumkbn
  • @stdlib/blas/ext/base/dapxsumkbn2
  • @stdlib/blas/ext/base/dapxsumors
  • @stdlib/blas/ext/base/dapxsumpw
  • @stdlib/blas/ext/base/dasumpw
  • @stdlib/blas/ext/base/dcusum
  • @stdlib/blas/ext/base/dcusumkbn
  • @stdlib/blas/ext/base/dcusumkbn2
  • @stdlib/blas/ext/base/dcusumors
  • @stdlib/blas/ext/base/dcusumpw
  • @stdlib/blas/ext/base/dfill
  • @stdlib/blas/ext/base/dnanasum
  • @stdlib/blas/ext/base/dnanasumors
  • @stdlib/blas/ext/base/dnannsum
  • @stdlib/blas/ext/base/dnannsumkbn
  • @stdlib/blas/ext/base/dnannsumkbn2
  • @stdlib/blas/ext/base/dnannsumors
  • @stdlib/blas/ext/base/dnannsumpw
  • @stdlib/blas/ext/base/dnansum
  • @stdlib/blas/ext/base/dnansumkbn
  • @stdlib/blas/ext/base/dnansumkbn2
  • @stdlib/blas/ext/base/dnansumors
  • @stdlib/blas/ext/base/dnansumpw
  • @stdlib/blas/ext/base/drev
  • @stdlib/blas/ext/base/dsapxsum
  • @stdlib/blas/ext/base/dsapxsumpw
  • @stdlib/blas/ext/base/dsnannsumors
  • @stdlib/blas/ext/base/dsnansum
  • @stdlib/blas/ext/base/dsnansumors
  • @stdlib/blas/ext/base/dsnansumpw
  • @stdlib/blas/ext/base/dsort2hp
  • @stdlib/blas/ext/base/dsort2ins
  • @stdlib/blas/ext/base/dsort2sh
  • @stdlib/blas/ext/base/dsorthp
  • @stdlib/blas/ext/base/dsortins
  • @stdlib/blas/ext/base/dsortsh
  • @stdlib/blas/ext/base/dssum
  • @stdlib/blas/ext/base/dssumors
  • @stdlib/blas/ext/base/dssumpw
  • @stdlib/blas/ext/base/dsum
  • @stdlib/blas/ext/base/dsumkbn
  • @stdlib/blas/ext/base/dsumkbn2
  • @stdlib/blas/ext/base/dsumors
  • @stdlib/blas/ext/base/dsumpw
  • @stdlib/blas/ext/base/sapx
  • @stdlib/blas/ext/base/sapxsum
  • @stdlib/blas/ext/base/sapxsumkbn
  • @stdlib/blas/ext/base/sapxsumkbn2
  • @stdlib/blas/ext/base/sapxsumors
  • @stdlib/blas/ext/base/sapxsumpw
  • @stdlib/blas/ext/base/sasumpw
  • @stdlib/blas/ext/base/scusum
  • @stdlib/blas/ext/base/scusumkbn
  • @stdlib/blas/ext/base/scusumkbn2
  • @stdlib/blas/ext/base/scusumors
  • @stdlib/blas/ext/base/scusumpw
  • @stdlib/blas/ext/base/sdsapxsum
  • @stdlib/blas/ext/base/sdsapxsumpw
  • @stdlib/blas/ext/base/sdsnansum
  • @stdlib/blas/ext/base/sdsnansumpw
  • @stdlib/blas/ext/base/sdssum
  • @stdlib/blas/ext/base/sdssumpw
  • @stdlib/blas/ext/base/sfill
  • @stdlib/blas/ext/base/snansum
  • @stdlib/blas/ext/base/snansumkbn
  • @stdlib/blas/ext/base/snansumkbn2
  • @stdlib/blas/ext/base/snansumors
  • @stdlib/blas/ext/base/snansumpw
  • @stdlib/blas/ext/base/srev
  • @stdlib/blas/ext/base/ssort2hp
  • @stdlib/blas/ext/base/ssort2ins
  • @stdlib/blas/ext/base/ssort2sh
  • @stdlib/blas/ext/base/ssorthp
  • @stdlib/blas/ext/base/ssortins
  • @stdlib/blas/ext/base/ssortsh
  • @stdlib/blas/ext/base/ssum
  • @stdlib/blas/ext/base/ssumkbn
  • @stdlib/blas/ext/base/ssumkbn2
  • @stdlib/blas/ext/base/ssumors
  • @stdlib/blas/ext/base/ssumpw
@kgryte kgryte added Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Dec 4, 2023
@kailash360
Copy link

@kgryte

Can I work on this issue?

@kgryte
Copy link
Member Author

kgryte commented Feb 25, 2024

@kailash360 Sure. How about you start with @stdlib/blas/ext/base/dapx.

@kgryte kgryte added difficulty: 3 Likely to be challenging but manageable. priority: High High priority concern or feature request. Accepted RFC feature request which has been accepted. C Issue involves or relates to C. labels Feb 25, 2024
@kailash360
Copy link

working on @stdlib/blas/ext/base/dapx.

@kgryte
Copy link
Member Author

kgryte commented Feb 25, 2024

@kailash360 You might find the various linked commits and PRs in the upstream issue to be good references. For example, 91a2bad, which makes updates to a single-precision API.

@kgryte
Copy link
Member Author

kgryte commented Feb 25, 2024

...and 3c82fe7, which makes updates to a complex number API.

@rxbryan
Copy link
Contributor

rxbryan commented Feb 26, 2024

Hi @kgryte I have started work on @stdlib/blas/ext/base/sapx.

Planeshifter added a commit that referenced this issue Apr 15, 2024
…ventions

PR-URL: #2080
Closes: #1525 
Ref: #1152

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 15, 2024
…onventions

PR-URL: #1740 
Closes: #1526 
Ref: #1152

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 15, 2024
…onventions

PR-URL: #2019
Closes: #1478 
Ref: #1152

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 16, 2024
…nventions

PR-URL: #2057
Closes: #1486 
Ref: #1152

---------

Signed-off-by: utkarsh_raj <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 17, 2024
… conventions

PR-URL: #1733
Closes: #1531 
Ref: #1152

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 17, 2024
…t conventions

PR-URL: #2082
Closes: #1481
Ref: #1152

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 17, 2024
…ventions

PR-URL: #1809
Closes:  #1527
Ref: #1152

---------

Signed-off-by: Athan Reines <[email protected]>
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Pranav Goswami <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]> 
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Pranav Goswami <[email protected]>
@kgryte kgryte pinned this issue Apr 20, 2024
Planeshifter added a commit that referenced this issue Apr 20, 2024
… conventions

PR-URL: #1735
Closes: #1529
Ref: #1152 

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 20, 2024
… conventions

PR-URL:  #2180
Closes: #1482 
Ref: #1152

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 20, 2024
…onventions

PR-URL: #1924
Closes: #1476 
Ref: #1152

---------

Signed-off-by: Raunak Kumar Gupta <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Pranav Goswami <[email protected]>
Planeshifter added a commit that referenced this issue Apr 20, 2024
…ntions

PR-URL: #1802 
Closes: #1540
Ref: #1152 

---------

Signed-off-by: Raunak Kumar Gupta <[email protected]>
Co-authored-by:  Pranav Goswami <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Pranav Goswami <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 22, 2024
…ct conventions

PR-URL: #2063
Closes: #1480 
Ref: #1152

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 22, 2024
…t conventions

PR-URL: #2079
Closes: #1479 
Ref: #1152

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 27, 2024
…nventions

PR-URL: #1770
Closes: #1537 
Ref: #1152

---------

Co-authored-by: Praveen Kumar <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]> 
Reviewed-by: Pranav Goswami <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Planeshifter added a commit that referenced this issue Apr 28, 2024
…nventions

PR-URL: #1905
Closes: #1539
Ref: #1152

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 28, 2024
…nventions

PR-URL: #2051 
Closes: #1498 
Ref: #1152

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 28, 2024
…nventions

PR-URL: #2007
Closes: #1500 
Ref: #1152

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Pranav Goswami <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 28, 2024
…ntions

PR-URL: #1874
Closes: #1535
Ref: #1152

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Apr 28, 2024
…onventions

PR-URL: #2055
Closes: #1499
Ref: #1152 

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue May 4, 2024
…nvention

PR-URL: #2227
Closes: #1528 
Ref: #1152

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Jun 25, 2024
…onventions

PR-URL: #2302
Closes: #1495
Ref: #1152

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter added a commit that referenced this issue Sep 2, 2024
PR-URL: #2804
Closes:  #1491 
Ref: #1152

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
@gururaj1512
Copy link
Contributor

Is this issue resolved completely? If not which packages are yet to be refactored

@Planeshifter
Copy link
Member

@gururaj1512 Double-checked and looks llke almost all are completed. @stdlib/blas/ext/base/snansumkbn2 is the only one that still has to be updated as far as I can tell.

Planeshifter added a commit that referenced this issue Oct 12, 2024
…nventions

PR-URL: #3002
Closes: #1530
Ref: #1152

Co-authored-by: Gururaj Gurram <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. Tracking Issue Tracking issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants