Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: refactor blas/ext/base/sdssum to follow current project conventions #1525

Closed
3 tasks done
Planeshifter opened this issue Mar 3, 2024 · 0 comments · Fixed by #2080
Closed
3 tasks done

[RFC]: refactor blas/ext/base/sdssum to follow current project conventions #1525

Planeshifter opened this issue Mar 3, 2024 · 0 comments · Fixed by #2080
Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.

Comments

@Planeshifter
Copy link
Member

Description

This RFC proposes refactoring @stdlib/blas/ext/base/sdssum to follow current project conventions.

These conventions are outlined in more detail in #788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include d66d80c (saxpy), 3c82fe7 (cswap), and 5b15c96 (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Planeshifter Planeshifter added Good First Issue A good first issue for new contributors! Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. JavaScript Issue involves or relates to JavaScript. labels Mar 3, 2024
@kunal-511 kunal-511 mentioned this issue Mar 6, 2024
Closed
1 task
@AmCodesLame AmCodesLame mentioned this issue Mar 27, 2024
Merged
1 task
Planeshifter added a commit that referenced this issue Apr 15, 2024
@AmCodesLame @Planeshifter
refactor: update blas/ext/base/sdssum to follow current project con…
c13b428 
…ventions

PR-URL: #2080
Closes: #1525 
Ref: #1152

---------

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.
Projects
None yet
Milestone
No milestone
1 participant
@Planeshifter