-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AI Editing Features #29
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎
Footnotes |
Hey @steven-tey ! Apparently, Tippy's maxWidth is set to 350px by default... However, changing that option alone doesn't give it full width. I had to directly target the Note: was looking at Notion's menu and i think that constraining the menu to be inside the text editor would be better. For reference: |
@redac thanks for looking into this! I tried constraining menu directly in the editor but that came with another trade off - I couldn't make sure that the menu was directly below the currently selected mode 😅 Also, the current approach causes the menu to move along with the cursor, which is incorrect as well. Looks like your idea of positioning it directly in the editor might be better after all - we just need to figure out how to make sure it's aligned properly to the currently selected node. |
Hey I gave it a go on this PR into this same branch: #32 https://www.loom.com/share/33babc8605da4f179894d3aa44c80e05?sid=6491ce36-aa1f-48d2-9948-5dae43c2130b it's not quite right though! On this line: https:/GraemeFulton/novel/blob/490a8cbf008edb9322785566935b3b840fd99c60/ui/editor/components/bubble-menu/ai.tsx#L69, I minus 120 from the left offset, which made it go in the right place during testing with no suggestion: but when there is a suggestion, it looks like that pulls it to the left too far: It's a good starting point and show you how to modify the positioning though! |
ad042ab
to
0a57350
Compare
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. What is telemetry?This package contains telemetry which tracks you. Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
I would really like this one to succeed. It would be a core feature of my app. How can I help contribute. What seems to be the issue which is preventing this to come out? |
I'll close this PR because I opened a new one here #297 |
This PR adds a "highlight + edit with AI" feature to Novel.
It's adds an "Ask AI" dropdown to the
EditorBubbleMenu
component and another custom bubblemenu component (AIBubbleMenu
) to show the changes.However, as you can see from the screenshot above, the
AIBubbleMenu
component can't expand to the full width of the editor for some reason :/Would love some help with this!
cc: Tiptap wizard @sereneinserenade 🙏