Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: full width ai bubble menu #30

Closed
wants to merge 1 commit into from
Closed

Conversation

redac
Copy link
Contributor

@redac redac commented Jun 21, 2023

Apparently, Tippy's maxWidth is set to 350px by default...

However, changing that option alone doesn't give it full width. I had to directly target the tippy-2 element to get this to work. (see #30)

image

Note: was looking at Notion's menu and i think that constraining the menu to be inside the text editor would be better. For reference:

image

@vercel
Copy link

vercel bot commented Jun 21, 2023

@redac is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@redac redac mentioned this pull request Jun 21, 2023
@steven-tey
Copy link
Owner

steven-tey commented Jun 21, 2023

@redac this looks awesome – thank you! Can you please make this PR against the ai-edit branch instead? It's a bit hard to tell which code changes did you make 😅

@redac redac changed the base branch from main to ai-edit June 22, 2023 05:54
@redac
Copy link
Contributor Author

redac commented Jun 22, 2023

@steven-tey Just changed the PR's base to ai-edit, does that do it? 😅

@steven-tey
Copy link
Owner

@redac yes, thank you! Will take a look today!

@steven-tey
Copy link
Owner

Closing this for now – will need to rethink the UI 😅 thanks though!

@steven-tey steven-tey closed this Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants