[SW-1244] Move accounts vuex state to composable #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peronczyk
force-pushed
the
refactor/move-account-vuex-state-to-composable
branch
10 times, most recently
from
7b464ed
to
1b5503b
Compare
peronczyk
changed the title
pstachel
reviewed
Sep 18, 2023
peronczyk
force-pushed
the
refactor/move-account-vuex-state-to-composable
branch
2 times, most recently
from
514fef1
to
94c7d99
Compare
peronczyk
force-pushed
the
refactor/move-account-vuex-state-to-composable
branch
from
94c7d99
to
0c703d9
Compare
konradodo
suggested changes
Sep 18, 2023
konradodo
approved these changes
Sep 18, 2023
peronczyk
force-pushed
the
refactor/move-account-vuex-state-to-composable
branch
10 times, most recently
from
1b4ec73
to
4517307
Compare
peronczyk
force-pushed
the
refactor/move-account-vuex-state-to-composable
branch
from
4517307
to
0a0202f
Compare
pstachel
approved these changes
Sep 26, 2023
subhod-i
requested changes
Sep 27, 2023
peronczyk
force-pushed
the
refactor/move-account-vuex-state-to-composable
branch
from
0a0202f
to
d927c81
Compare
subhod-i
requested changes
Sep 27, 2023
subhod-i
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Code changes LGTM, We need to test this if the changes in the PR can read the existing storage keys and their data. @Liubov-crypto Please use the develop branch and make sure to have an account with few interactions and then use this PR to check the existing state is continued/resumed.
peronczyk
force-pushed
the
refactor/move-account-vuex-state-to-composable
branch
from
66985da
to
51c7e86
Compare
CedrikNikita
approved these changes
Sep 27, 2023
peronczyk
force-pushed
the
refactor/move-account-vuex-state-to-composable
branch
from
fc1088e
to
e255040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.