-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
building issue in production with some NPM packages #7085
Comments
I saw this issue #6440, found now bundle everything in devDependencies. I moved |
Yes, bundling everything should work. I believe the primary error from running in an unbundled fashion is coming from salesforce/tough-cookie#256 I'm going to close this in favor of that issue since the issue is not in SvelteKit itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
We are trying to migrate our sveltekit from
1.0.0-next.355
to the latest version -1.0.0-next.504
, and adapter-node from1.0.0-next.78
to1.0.0-next.95
.yarn run dev
andyarn run build -> yarn run preview
are successfully done, but when I launch server by nodejs throughnode build/index.js
.I asked this issue in discord, I got few responses. Someone said there is similar issue when he migrated from esbuild to rollup, and
adapter-node
also migrated from esbuild since v93.I think our source code migration is done correctly according to the sveltekit guideline, but I guess there is some building issue by adapter-node or vite with some of NPM packages since adapter-node changed from esbuild to rollup.
Reproduction
I found there are at least two endpoints in our project having building issue in sveltekit. I created a very minimal project with the latest sveltekit version.
Please follow the reproduction procedure in README.md at the following repository,
https:/UNDP-Data/sveltekit-build-test
Furthermore, I created another branch in the repo which has downgraded sveltekit.
https:/UNDP-Data/sveltekit-build-test/tree/downgrade-sveltekit
You can compare both main branch and downgrade-sveltekit branch how the server works in production by using
node build
Logs
The following log is when I downgraded
adapter-node
to1.0.0-next.92
.Other logs for our testing source code are in UNDP-Data/sveltekit-build-test repo's README.
System Info
Our server is running in Azure AppService. The following log was generated in our repository in my laptop.
The following log is for our testing repository UNDP-Data/sveltekit-build-test. Also, it was generated in my laptop.
Severity
blocking an upgrade
Additional Information
Yesterday, I posted the same one in discussion (#7069).
The text was updated successfully, but these errors were encountered: