Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): migrate Nethermind's preconf contracts here #18234

Open
wants to merge 32 commits into
base: ontake_cleanup2
Choose a base branch
from

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Oct 11, 2024

This PR copies Nethermind's preconfirmation contract and makes a few modifications to align with Taiko's Solidity coding conventions while keeping most of the ABIs unchanged.

I also addedd eigenlayer depedencies and decoupled preconf interfaces from eigenlayer-mvp

@dantaik dantaik marked this pull request as ready for review October 11, 2024 04:58
Copy link

openzeppelin-code bot commented Oct 11, 2024

feat(protocol): migrate Nethermind's preconf contracts here

Generated at commit: 2e51324ad8c7b28ec19bde2d85867f1888cbc4d1

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
7
42
55
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik force-pushed the nethermind_preconf_contracts_migration branch from 5311dc1 to acbd89a Compare October 11, 2024 06:14
@dantaik dantaik changed the title feat(protocol): migrate Nethermind's preconf contracts and tests here feat(protocol): preconf: migrate Nethermind's contracts Oct 11, 2024
@dantaik dantaik changed the base branch from nethermind_preconf_contracts_migration to ontake_cleanup2 October 11, 2024 06:29
@dantaik dantaik changed the title feat(protocol): preconf: migrate Nethermind's contracts feat(protocol): migrate Nethermind's preconf contracts here Oct 11, 2024
@dantaik
Copy link
Contributor Author

dantaik commented Oct 12, 2024

Ready to review.

@dantaik dantaik added option.pinned Will not be marked as stale automatically option.do-not-merge area.protocol and removed option.pinned Will not be marked as stale automatically option.do-not-merge labels Oct 12, 2024
@dantaik dantaik self-assigned this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant