Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust z0 normal scale #200

Merged
merged 1 commit into from
Dec 19, 2017
Merged

adjust z0 normal scale #200

merged 1 commit into from
Dec 19, 2017

Conversation

meetar
Copy link
Member

@meetar meetar commented Oct 25, 2017

Adjusted the normal-scaling function at low zooms – the effect is eased in through z1 and a very small amount at z2.

Using a custom local test in the differ (new style on the left, old in the middle, differing pixels in red on the right):

screen shot 2017-10-25 at 3 55 09 pm

screen shot 2017-10-25 at 3 54 32 pm

By z2 the effect is only barely perceptible in the most extreme slopes, like this one in Greenland:

screen shot 2017-10-25 at 3 55 51 pm

Past that you see the odd slight difference in a pixel here or there up to around z12:

screen shot 2017-10-25 at 4 01 05 pm

screen shot 2017-10-25 at 4 00 53 pm

@meetar
Copy link
Member Author

meetar commented Nov 8, 2017

resolves #198

@meetar meetar requested a review from nvkelso December 19, 2017 17:42
Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvkelso nvkelso merged commit 43a27a9 into gh-pages Dec 19, 2017
@nvkelso nvkelso deleted the meetar/z0-normals-adjust branch December 19, 2017 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants