Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Added missing sentence periods #1108

Merged
merged 2 commits into from
Apr 19, 2018
Merged

Editorial: Added missing sentence periods #1108

merged 2 commits into from
Apr 19, 2018

Conversation

js-choi
Copy link
Contributor

@js-choi js-choi commented Feb 20, 2018

Fixes #1106.
First pull request. RFTG Contributor Form signed.

ljharb
ljharb approved these changes Feb 20, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@js-choi js-choi changed the title Editorial: Added missing sentence period, § Lexical Environments Editorial: Added missing sentence periods Feb 20, 2018
@ljharb ljharb requested review from bterlson and bmeck April 1, 2018 04:32
@bterlson
Copy link
Member

@js-choi is this really your first accepted PR? Congrats!!

@bterlson bterlson merged commit d8974e9 into tc39:master Apr 19, 2018
@ljharb ljharb mentioned this pull request May 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@bterlson bterlson Awaiting requested review from bterlson

@bmeck bmeck Awaiting requested review from bmeck

Assignees

@bterlson bterlson

Labels
editorial change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@js-choi @bterlson @ljharb @michaelficarra