Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ES2018 from master #1191

Closed
wants to merge 5 commits into from
Closed

Update ES2018 from master #1191

wants to merge 5 commits into from

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented May 10, 2018

This contains all the commits on master prior to #1112:

I think it would be OK to also include the following (but haven't yet) - thoughts?:

littledan and others added 2 commits April 19, 2018 13:42
@littledan @bterlson
Layering: Check for the correct owner in DetachArrayBuffer (#1112)
cff300b 
* Layering: Check for the correct owner in DetachArrayBuffer

This patch gives ArrayBuffers an "owner" internal slot. This slot is
used to throw a TypeError on inappropriate DetachArrayBuffer calls.

WebAssembly needs it to be an error to detach an ArrayBuffer (e.g.,
through postMessage) for ArrayBuffers which come from
WebAssembly.Memory objects. It should only be the Memory grow
operation which ever detaches this ArrayBuffer.

* Editorial: Clarifications based on code review
@jmdyck @bterlson
Editorial: Misc Editorial (#1182)
cbe4679 
* Editorial: "is not provided" -> "is not present"

(See PR #953.)

* Editorial: put '!' before ToInteger() invocation

... otherwise the comparison to _length_ is a bit odd.

* Editorial: 'let' -> 'set'
@ljharb ljharb requested review from bterlson and bmeck May 10, 2018 22:39
@littledan
Copy link
Member

I think we discussed in the March meeting omitting #1112 from ES2018. I see no reason to rush it.

@ljharb
Copy link
Member Author

ljharb commented May 10, 2018

That's why I didn't include it, and it's fine to leave it out :-) just would make this merge cleaner.

@bterlson
Copy link
Member

#1182 can come I think. Otherwise this looks good to me, thank you for taking a look! I can hit the merge button once #1182 is included here (or I'll mix it in later).

@bterlson bterlson assigned ljharb and unassigned bterlson May 14, 2018
@ljharb
Copy link
Member Author

ljharb commented May 14, 2018

The PR's base branch seems to be a bit messed up; I'll merge this manually (as discussed with @bterlson) and close this PR.

@jmdyck @bterlson
Editorial: clarify that [[Construct]] implies [[Call]] (#1187)
a956a03 
* Editorial: clarify that [[Construct]] implies [[Call]]

That is, an object with a [[Construct]] internal method
must have a [[Call]] internal method.
Previously, this was assumed but not explicitly stated.

See https://stackoverflow.com/questions/50109554/

* Editorial: Add 'additionally'
@ljharb
Copy link
Member Author

ljharb commented May 14, 2018

The es2018 branch has now been updated. It's now effectively identical to master at 38a771f, minus the layering change at cff300b / #1112.

@ljharb ljharb closed this May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bterlson bterlson Awaiting requested review from bterlson

@bmeck bmeck Awaiting requested review from bmeck

Assignees

@ljharb ljharb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ljharb @littledan @bterlson @jmdyck @mysticatea