Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Make Async-from-Sync iterator object inaccessible to ECMAScript code #1474

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Normative: Make Async-from-Sync iterator object inaccessible to ECMAScript code #1474

merged 1 commit into from
Jun 19, 2019
+10 −23

Conversation

anba
Copy link
Contributor

@anba anba commented Mar 11, 2019

Fixes #1172

b4708ca

  • Instead of adding a new intrinsic, this PR simply performs a Get to retrieve the "next" method.

e4516b0

  • Remove non-observable behaviour from Async-from-Sync iterator objects.

@anba anba mentioned this pull request Mar 11, 2019
Merged
@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text needs consensus This needs committee consensus before it can be eligible to be merged. web reality labels Mar 11, 2019
@ljharb ljharb requested review from zenparsing, ljharb, domenic and a team March 11, 2019 18:38
@ljharb ljharb changed the title Make Async-from-Sync iterator object inaccessible to ECMAScript code Normative: Make Async-from-Sync iterator object inaccessible to ECMAScript code Mar 15, 2019
zenparsing
zenparsing reviewed Mar 26, 2019
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@ljharb ljharb added has consensus This has committee consensus. and removed needs consensus This needs committee consensus before it can be eligible to be merged. labels Mar 26, 2019
@ljharb ljharb self-assigned this Jun 19, 2019
ljharb
ljharb approved these changes Jun 19, 2019
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@anba @ljharb
Normative: Make Async-from-Sync iterator object inaccessible to ECMAS…
1245393 
…cript code

Fixes tc39#1172

Add assertions and note that Async-from-Sync iterator instances are not directly accessible

- Replace type checks with assertions in "next", "return", and "throw" methods.
- Remove `@@toStringTag` because it's never accessed.
- Add note Async-from-Sync Iterator instances cannot be accessed from ECMAScript code.

Drive-by:
- Change "`value` field" to "`value` property".
- Change "async iterator value unwrap function" to "async-from-sync iterator value unwrap function".

Fixes tc39/proposal-async-iteration#105
@ljharb ljharb force-pushed the async-from-sync-iter-inaccessible branch from e4516b0 to 1245393 Compare June 19, 2019 21:25
@ljharb ljharb merged commit 1245393 into tc39:master Jun 19, 2019
devsnek
devsnek reviewed Jun 19, 2019
View reviewed changes
spec.html Show resolved Hide resolved
@bakkot bakkot mentioned this pull request Oct 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@devsnek devsnek devsnek left review comments

@zenparsing zenparsing zenparsing approved these changes

@domenic domenic Awaiting requested review from domenic

Assignees

@ljharb ljharb

Labels
has consensus This has committee consensus. normative change Affects behavior required to correctly evaluate some ECMAScript source text web reality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Async-from-Sync iterator object inaccessible to ECMAScript code
4 participants
@anba @ljharb @devsnek @zenparsing