Test cases for async function and async generator edge-cases #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Continuation Issue: tc39/ecma262#1461 PR: tc39/ecma262#1470
adrianheine
reviewed
Mar 11, 2019
| .then(() => actual.push("tick 1")) | ||
| .then(() => actual.push("tick 2")) | ||
| .then(() => { | ||
| assert.compareArray(actual, expected, "Ticks for implicit and explicit return undefined"); |
There was a problem hiding this comment.
This doesn't actually test the return values, does it?
There was a problem hiding this comment.
Correct, it doesn't test that each of the async generators actually returns undefined. But that was actually intentional, because the test should only ensure that the async generators finish at the correct turn. :-)
There was a problem hiding this comment.
Ok, that sounds right :) Then the assertion text should be changed.
leobalter
reviewed
Mar 13, 2019
| "get return", | ||
|
|
||
| // "then" of `received.[[Value]]` accessed. | ||
| "get then", |
leobalter
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases for https://bugzilla.mozilla.org/show_bug.cgi?id=1530754 and other related issues I found (or found again), like tc39/ecma262#1474 and tc39/ecma262#1470, while working on that bug.
SpiderMonkey passes these tests locally with https://bugzilla.mozilla.org/show_bug.cgi?id=1530754 fixed. (Some of the tests fail on V8/JSC, so don't be surprised if you see any errors.)