Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement version command or argument #445

Closed
pvalena opened this issue Nov 18, 2020 · 3 comments
Closed

Implement version command or argument #445

pvalena opened this issue Nov 18, 2020 · 3 comments
Assignees
@psss
Labels
good first issue Good for newcomers
Milestone
1.3

Comments

@pvalena
Copy link
Collaborator

pvalena commented Nov 18, 2020 •
edited
Loading 

$ tmt version
Usage: tmt [OPTIONS] COMMAND [ARGS]...
Try 'tmt --help' for help.

Error: No such command 'version'.

$ tmt --version
Usage: tmt [OPTIONS] COMMAND [ARGS]...
Try 'tmt --help' for help.

Error: no such option: --version
@martinky82
Copy link

Version is currently stored only in tmt.spec. I wonder, would implementing this feature require storing the version somewhere in the code itself?

Brainstorming: in the code ifself (base.py), there would an artificial value that would translate into 'git snapshot', 'not a released version' or whatever in the message printed by --version. During build, this artificial value would be overwritten by %version (simple sed -i).

Thoughts?

@psss psss self-assigned this Feb 17, 2021
@psss psss added this to the 1.3 milestone Feb 17, 2021
psss added a commit that referenced this issue Feb 17, 2021
@psss
Implement the 'tmt --version' option [fix #445]
70d9c93 
Instead of hard coding the version into the sources let's replace
the default string before building the packages.
@psss
Copy link
Collaborator

psss commented Feb 17, 2021

The new --version option implemented in #561.

@pvalena
Copy link
Collaborator Author

pvalena commented Feb 17, 2021

Thanks!

@pvalena pvalena closed this as completed Feb 17, 2021
@psss psss changed the title RFE: implement version command or argument Implement version command or argument Feb 20, 2021
psss added a commit that referenced this issue Feb 22, 2021
@psss
Implement the 'tmt --version' option [fix #445]
722dedc 
Instead of hard coding the version into the sources let's replace
the default string before building the packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psss psss

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
3 participants
@psss @martinky82 @pvalena