Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the 'tmt --version' option [fix #445] #561

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Implement the 'tmt --version' option [fix #445] #561

merged 1 commit into from
Feb 22, 2021

Conversation

psss
Copy link
Collaborator

@psss psss commented Feb 17, 2021

Instead of hard coding the version into the sources let's replace
the default string before building the packages.

@psss psss added the code | cli Changes related to the command line interface label Feb 17, 2021
@psss psss self-assigned this Feb 17, 2021
@psss psss added this to the 1.3 milestone Feb 17, 2021
@psss psss mentioned this pull request Feb 17, 2021
Closed
pvalena
pvalena approved these changes Feb 17, 2021
View reviewed changes
Copy link
Collaborator

@pvalena pvalena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Makefile Show resolved Hide resolved
lukaszachy
lukaszachy requested changes Feb 18, 2021
View reviewed changes
Copy link
Collaborator

@lukaszachy lukaszachy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that module.__version__ version is a standard. We should stick to it.

tmt/cli.py Outdated Show resolved Hide resolved
@psss psss requested a review from lukaszachy February 19, 2021 17:12
lukaszachy
lukaszachy approved these changes Feb 22, 2021
View reviewed changes
Copy link
Collaborator

@lukaszachy lukaszachy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

thrix
thrix approved these changes Feb 22, 2021
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psss
Implement the 'tmt --version' option [fix #445]
722dedc 
Instead of hard coding the version into the sources let's replace
the default string before building the packages.
@psss psss merged commit 722dedc into master Feb 22, 2021
@psss psss deleted the version branch February 22, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@lukaszachy lukaszachy lukaszachy approved these changes

@pvalena pvalena pvalena approved these changes

@hegerj hegerj hegerj approved these changes

@FrNecas FrNecas Awaiting requested review from FrNecas

Assignees

@psss psss

Labels
code | cli Changes related to the command line interface
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@psss @thrix @lukaszachy @pvalena @hegerj