Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primitives for loading and saving step results [Step results #3] #2978

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Jun 2, 2024

Pull Request Checklist

Depends on #2977

  • implement the feature

@happz happz added this to the 1.35 milestone Jun 2, 2024
@happz happz mentioned this pull request Jun 7, 2024
3 tasks
@happz happz force-pushed the plugins-introduce-phase-result branch from 9ab154f to 6b6e65c Compare June 15, 2024 11:04
@happz happz force-pushed the plugins-save-results-primitives branch from a99ccb4 to 8e75089 Compare June 15, 2024 11:38
@happz happz added the ci | full test Pull request is ready for the full test execution label Jun 15, 2024
@happz happz changed the title Add primitives for loading and saving step results Add primitives for loading and saving step results [Step results #3] Jun 15, 2024
@happz happz marked this pull request as ready for review June 15, 2024 12:14
@happz happz added the code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. label Jun 15, 2024
@happz happz force-pushed the plugins-introduce-phase-result branch from 6b6e65c to 122d18c Compare July 30, 2024 21:21
@happz happz force-pushed the plugins-introduce-phase-result branch from 122d18c to 54ede40 Compare July 31, 2024 17:26
Base automatically changed from plugins-introduce-phase-result to main August 1, 2024 07:04
Copy link
Collaborator

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@happz happz modified the milestones: 1.35, 1.36 Aug 1, 2024
@happz happz force-pushed the plugins-save-results-primitives branch from a670359 to d315345 Compare August 6, 2024 18:10
@happz happz added the status | blocked The merging of PR is blocked on some other issue label Aug 6, 2024
@happz
Copy link
Collaborator Author

happz commented Aug 6, 2024

Blocked on #3106 - after swapping phase results for subresults, we can add the actual (step) phase result class.

@happz happz force-pushed the plugins-save-results-primitives branch from d315345 to a4139c5 Compare August 11, 2024 10:26
@happz
Copy link
Collaborator Author

happz commented Aug 12, 2024

Unrelated failure, merging.

@happz happz merged commit 9d51a63 into main Aug 12, 2024
19 of 20 checks passed
@happz happz deleted the plugins-save-results-primitives branch August 12, 2024 07:08
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. status | blocked The merging of PR is blocked on some other issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants