Extend coverage of prepare/finish ansible plugin with more images #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
step | prepare
happz
requested review from
psss,
lukaszachy,
thrix and
janhavlin
as code owners
therazix
approved these changes
Jul 30, 2024
happz
added
status | ready for merge
happz
force-pushed
the
ansible-test-container-and-virtual
branch
4 times, most recently
from
91d0368
to
6a9f992
Compare
KwisatzHaderach
approved these changes
Jul 31, 2024
The coverage now matches what `prepare/install` is tested with. This change required refactoring of some bits of `prepare/install` test: * moving generic helpers into `tests/install.sh`, * changing tests for `ansible` plugin to use `tests/images.sh` instead of its original one-shot use of images. This gives us: * the same coverage for both plugins, * one place where new environment needs to be added, * less code duplication, more re-use of "image testing" helpers, * and, the best, it actually discovers a genuine bug: `ansible` plugins did not report Python interpreter as their essential requirement, therefore playbooks were impossible to run in some environments.
happz
force-pushed
the
ansible-test-container-and-virtual
branch
from
375d1c7
to
b3221aa
Compare
|
Unrelated failures, merging. |
The-Mule
pushed a commit
to The-Mule/tmt
that referenced
this pull request
Oct 14, 2024
…emtee#3110) The coverage now matches what `prepare/install` is tested with. This change required refactoring of some bits of `prepare/install` test: * moving generic helpers into `tests/install.sh`, * changing tests for `ansible` plugin to use `tests/images.sh` instead of its original one-shot use of images. This gives us: * the same coverage for both plugins, * one place where new environment needs to be added, * less code duplication, more re-use of "image testing" helpers, * and, the best, it actually discovers a genuine bug: `ansible` plugins did not report Python interpreter as their essential requirement, therefore playbooks were impossible to run in some environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage now matches what
prepare/installis tested with. This change required refactoring of some bits ofprepare/installtest:tests/install.sh,ansibleplugin to usetests/images.shinstead of its original one-shot use of images.This gives us:
ansibleplugins did not report Python interpreter as their essential requirement, therefore playbooks were impossible to run in some environments.Pull Request Checklist