Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend coverage of prepare/finish ansible plugin with more images #3110

Merged
merged 1 commit into from
Aug 2, 2024

Commits on Aug 2, 2024

  1. Extend coverage of prepare/finish ansible plugin with more images

    The coverage now matches what `prepare/install` is tested with. This
    change required refactoring of some bits of `prepare/install` test:
    
    * moving generic helpers into `tests/install.sh`,
    * changing tests for `ansible` plugin to use `tests/images.sh` instead
    of its original one-shot use of images.
    
    This gives us:
    
    * the same coverage for both plugins,
    * one place where new environment needs to be added,
    * less code duplication, more re-use of "image testing" helpers,
    * and, the best, it actually discovers a genuine bug: `ansible` plugins
      did not report Python interpreter as their essential requirement,
      therefore playbooks were impossible to run in some environments.
    happz committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    b3221aa View commit details
    Browse the repository at this point in the history