github enterprise support for pullrequest pipeline resource #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
|
tekton-robot
added
the
size/M
akihikokuroda
force-pushed
the
ghesupport
branch
from
6cec8e9
to
e7de56f
Compare
|
/retest |
vdemeester
reviewed
Jul 2, 2019
|
/approve |
tekton-robot
added
the
approved
wlynch
reviewed
Jul 2, 2019
The pull request resource supports only public github. This PR adds the support for the enterprise github. When the url in the pull request resource has the base url other than "github.com", it sets the url as the base url for the pull request.
tekton-robot
added
size/L
|
/retest |
|
/approve |
|
/test pull-tekton-pipeline-integration-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akihikokuroda, vdemeester, wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Fixing |
|
/check-cla |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request resource supports only public github. This PR adds the support for the enterprise github. When the url in the pull request resource has the base url other than "github.com", it sets the url as the base url for the pull request.
Test for the NewGitHubHandler is added in cmd/pullrequest-init/github_test.go
Changes
When the url in the pull request resource has the base url other than "github.com", it sets the url as the base url for the pull request.
Code changes are in NewGitHubHandler in cmd/pullrequest-init/github.go
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes