skaffold: use a working revision instead of master #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent changes in `GoogleContaineTools/skaffold` broked the examples (and thus the CI it seems). Let's use a revision we know works instead of depending on random changes. A better option would be to use `pipeline` itself in the example, but that can be done later on. Signed-off-by: Vincent Demeester <[email protected]>
googlebot
added
the
cla: yes
tekton-robot
added
approved
3 tasks
afrittoli
approved these changes
Jul 3, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
haha classic 🤦♀ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Recent changes in
GoogleContaineTools/skaffoldbroked theexamples (and thus the CI it seems). Let's use a revision we know
works instead of depending on random changes.
A better option would be to use
pipelineitself in the example, butthat can be done later on.
This should fix the CI on pull requests.
/cc @bobcatfish
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.