-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tutorial.md: docker-server value for Docker Hub #3298
Conversation
See comment in #2616 Most people are used to 'docker.io' as server for Docker Hub and not 'index.docker.io'. The tutorial doesn't work with 'docker.io', so defining the value clearly in case of widely-used Docker Hub may be useful. Best, Didier
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @didier-durand. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @didier-durand!
/ok-to-test
@@ -237,6 +237,7 @@ kubectl create secret docker-registry regcred \ | |||
--docker-password=<your-pword> \ | |||
--docker-email=<your-email> | |||
``` | |||
(If Docker Hub is used, then arg docker-server must be set to 'index.docker.io') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, we tend to put these caveats after a **Note:**
to ensure users don't miss them, as shown in this snippet from another part of this tutorial:
Line 14 in b7e2505
**Note:** Items requiring configuration are marked with the `#configure` annotation. |
/kind documentation |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
@jerop : no interest in merging this typo fix? Didier |
@didier-durand i believe @jerop made a comment here #3298 (comment) and it probably can get merged quickly after that when this is addressed, |
See comment in #2616
Most people are used to 'docker.io' as server for Docker Hub and not 'index.docker.io'. The tutorial doesn't work with 'docker.io', so defining the value clearly in case of widely-used Docker Hub may be useful.
Best,
Didier
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes