Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tutorial.md: docker-server value for Docker Hub #3298

Closed
wants to merge 1 commit into from
Closed

tutorial.md: docker-server value for Docker Hub #3298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/tutorial.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ kubectl create secret docker-registry regcred \
--docker-password=<your-pword> \
--docker-email=<your-email>
```
(If Docker Hub is used, then arg docker-server must be set to 'index.docker.io')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, we tend to put these caveats after a **Note:** to ensure users don't miss them, as shown in this snippet from another part of this tutorial:

pipeline/docs/tutorial.md

Line 14 in b7e2505

**Note:** Items requiring configuration are marked with the `#configure` annotation.


You must also specify a `ServiceAccount` that uses this `secret` to execute your `TaskRun`:

Expand Down