Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add customizable Auto Scaling Group health check type #1118

Merged
merged 2 commits into from
Dec 22, 2020
Merged

feat: Add customizable Auto Scaling Group health check type #1118

merged 2 commits into from
Dec 22, 2020

Conversation

svaranasi-corporate
Copy link
Contributor

@svaranasi-corporate svaranasi-corporate commented Nov 23, 2020

PR o'clock

Description

Adding the ability to define health-check type for autoscaling groups. I saw this issue without a PR, so this is that.

Checklist

@svaranasi-corporate
Copy link
Contributor Author

Hello there! Just wondering if there's anything else that you need from me before you review this PR, or if it's just a wait and watch thingy.

@svaranasi-corporate
Copy link
Contributor Author

I'd love if someone could take a quick look at this PR. Please let me know if you need any further information to help this get merged. Thanks!

@svaranasi-corporate
Copy link
Contributor Author

Anybody?

@barryib barryib changed the title improvement: Customizable ASG health check type feat: Add customizable Auto Scaling Group health check type Dec 22, 2020
Copy link
Member

@barryib barryib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @svaranasi-traderev

@barryib barryib merged commit ccacc17 into terraform-aws-modules:master Dec 22, 2020
@svaranasi-corporate svaranasi-corporate deleted the ASG-health-check-type branch March 19, 2021 08:44
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants