Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Drop spot-instances-request from tag_specifications #2363

Merged
merged 2 commits into from
Dec 20, 2022
Merged

fix: Drop spot-instances-request from tag_specifications #2363

merged 2 commits into from
Dec 20, 2022

Conversation

pavlospt
Copy link
Contributor

Description

spot-instances-request is not supported in some regions, so we are dropping that from default tag_specifications.

Motivation and Context

@pavlospt pavlospt changed the title Drop spot-instances-request from tag_specifications fix: Drop spot-instances-request from tag_specifications Dec 20, 2022
@bryantbiggs
Copy link
Member

so far I have only heard one user report one region (Ireland) - so I am less inclined to drop this one since its not as problematic. do you know what other regions do not support this?

@lordspacehog
Copy link
Contributor

It also causes issues if you try to launch node groups without using spot instances at all. much like the Elastic GPU instances it doesn't allow you to specify the tag if you're not launching spot instances.

@bryantbiggs
Copy link
Member

yes I understand the behavior - that was a bit surprising when it was discovered with the tagging request for GPUs. However, this still appears to be isolated to one region so far (that I can tell - docs are not producing any additional results so far)

@pavlospt
Copy link
Contributor Author

@bryantbiggs even if it is incosistency with just one region, why should it not be fixed? I mean AWS should be supposedly consistent, but since they are not IMO it feels wrong to enforce such a change and possibly be breaking even just this one region!

@bryantbiggs bryantbiggs merged commit e391a99 into terraform-aws-modules:master Dec 20, 2022
@bryantbiggs
Copy link
Member

Failed: You cannot specify tags for Spot instances requests if there are no Spot instances requests being created by the request. Launching EC2 instance failed. - well this is some somewhat surprising behavior so yes, reverting this out and making it an opt in

antonbabenko pushed a commit that referenced this pull request Dec 20, 2022
@semantic-release-bot
chore(release): version 19.4.2 [skip ci]
1f1cb3a 
### [19.4.2](v19.4.1...v19.4.2) (2022-12-20)

### Bug Fixes

* Drop spot-instances-request from tag_specifications ([#2363](#2363)) ([e391a99](e391a99))
@antonbabenko
Copy link
Member

This PR is included in version 19.4.2 🎉

@pavlospt pavlospt deleted the chore/drop-spot-instance-requests-from-tag-specifications branch December 20, 2022 18:26
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Jan 4, 2023
@pavlospt @bryantbiggs @spr-mweber3
fix: Drop spot-instances-request from tag_specifications (terraform-a…
0dc7462 
…ws-modules#2363)

* Drop spot-instances-request from tag_specifications

* fix: Update documentation

Co-authored-by: Bryant Biggs <[email protected]>
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Jan 4, 2023
@semantic-release-bot @spr-mweber3
chore(release): version 19.4.2 [skip ci]
407cea6 
### [19.4.2](terraform-aws-modules/terraform-aws-eks@v19.4.1...v19.4.2) (2022-12-20)

### Bug Fixes

* Drop spot-instances-request from tag_specifications ([terraform-aws-modules#2363](terraform-aws-modules#2363)) ([e391a99](terraform-aws-modules@e391a99))
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavlospt @bryantbiggs @lordspacehog @antonbabenko