Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Some ideas for testcontainers-go #1536

Open
6 of 11 tasks
mmorel-35 opened this issue Aug 25, 2023 · 6 comments
Open
6 of 11 tasks

[Enhancement]: Some ideas for testcontainers-go #1536

mmorel-35 opened this issue Aug 25, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@mmorel-35
Copy link
Contributor

mmorel-35 commented Aug 25, 2023

Proposal

There are several ideas I can see concerning testcontainers-go, some concerning modulegen, some concerning the CI/CD.

Modulegen

CI/CD

  • Provide code coverage to sonarcloud (starting with main module) chore(ci): enable code coverage on Sonarcloud #1518
  • Generate sonar-project.properties per module/example ?
  • Change dependabot updates schedule interval to "weekly" to address updates more frequently so it doesn't become an epic task every month ?
  • Move Image of the example/module to a Dockerfile to be able to receive updates from dependabot ?
  • trigger a go mod tidy on every module depending on the main one when it is modified

I'm much more focused on modulegen for the moment

@mmorel-35 mmorel-35 added the enhancement New feature or request label Aug 25, 2023
@mdelapenya
Copy link
Member

Change dependabot updates schedule interval to "weekly" to address updates more frequently so it doesn't become an epic task every month ?

We already had that schedule, and there were lots of updates, exhausting the free tier of our GH actions workers across the entire testcontainers organisation.

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Aug 25, 2023

I guess that at that time there was no groups for the updates. Would it helps smooth the process?
Another option would be to replace dependabot with renovate.

@mdelapenya
Copy link
Member

Move Image of the example/module to a Dockerfile to be able to receive updates from dependabot ?

Regarding this, I'd say no, as we want to keep modules stable, at least until we have a real support matrix (which we do not have). Also moving to a Dockerfile-based module will force users to build the image again and again.

Just in case, I'm exploring updatecli for certain updates

@mdelapenya
Copy link
Member

mdelapenya commented Aug 22, 2024

@mmorel-35 I have a working branch creating cmd/devtools as the primary way to run several things:

  • the module generator
  • the release shell script, migrated to Go
  • the Go bump shell script
  • checking that there are no containers running shell script
  • other administrative tasks that could come?

Would you like to take a look and review it if possible? I appreciate your valuable feedback about this kind of tasks

@mmorel-35
Copy link
Contributor Author

Hi @mdelapenya ,
Of course, please provide a PR or the branch I can review

@mdelapenya
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants