modulegen: use cobra instead of native golang flag #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
11 tasks
|
Hi @mdelapenya , |
mmorel-35
changed the title
mdelapenya
reviewed
Aug 30, 2023
mdelapenya
reviewed
Aug 30, 2023
mdelapenya
reviewed
Aug 31, 2023
There was a problem hiding this comment.
@mmorel-35 looks very promising! I added a few comments, not blockers, but wanted to check with you first before approving the PR (which is already done in my mind)
Signed-off-by: Matthieu MOREL <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Merging, as the CI always passed |
mdelapenya
approved these changes
Aug 31, 2023
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Sep 1, 2023
* main: chore: define interfaces for file and project generation (testcontainers#1568) chore(deps): bump mkdocs-material from 8.2.7 to 9.2.6 (testcontainers#1567) chore(deps): bump the all group in /modules/neo4j with 1 update (testcontainers#1562) chore(deps): bump the all group in /modules/clickhouse with 1 update (testcontainers#1563) chore(deps): bump the all group in /modules/localstack with 1 update (testcontainers#1564) Update actions/github-script to 6.4.1 (testcontainers#1561) chore: Update Pipenv to use Python 3.8 (testcontainers#1558) feat: convert NATS example into a module (testcontainers#1559) chore(deps): bump the all group in /modulegen with 1 update (testcontainers#1554) modulegen: use cobra instead of native golang flag (testcontainers#1550)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This uses cobra instead of golang native flag .
This replaces the commands
with
And
with
The documentation of the command is available with --help on every command
Why is it important?
This will help provide more commands to modulegen.
Related issues
Follow-ups
Add new commands, complete documentation of the existing commands, see documentation.