Added Discord rich presence and added extra properties to songInfo provider #124
Conversation
semvis123
commented
Jan 12, 2021
semvis123
commented
- Added Discord rich presence
- Added extra properties to songInfo provider:
| transport: 'ipc' | ||
| }); | ||
|
|
||
| const clientId = '790655993809338398'; |
There was a problem hiding this comment.
Quick question about the ID, did you register an application in Discord under your own account?
There was a problem hiding this comment.
uhm yes, but it can be changed to yours if you want :)
plugins/discord-rpc/back.js
Outdated
| @@ -0,0 +1,41 @@ | |||
| const DiscordRPC = require('discord-rpc'); | |||
There was a problem hiding this comment.
nit: would have just called the plugin discord (rpc being an implementation detail, it might not be necessary to have it in the plugin name)
There was a problem hiding this comment.
Ah no, sorry for the confusion, I was talking about the filename plugins/discord-rpc/back.js -> plugins/discord/back.js! The code looks good 👍
|
The individual discord account needs to have its respective youtube account connected in order to show valid information. Could this be written in some docs (README) on these changes with the other available plugins? |
|
@AlxBrn Hmm that shouldn't be necessary, I don't have my YouTube account connected to my Discord and it works fine for me. Have you restarted both discord and YouTube music before you checked? Also could you clarify what you mean with "in order to show valid information"? |
|
@semvis123 Would it be possible to rename the client to YouTube Music instead of Youtube Music? :p |
|
@NNowakowski It should be updated right now, thanks for your suggestion! |
