Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: fix the Mode tooltip, and make sure the tooltip icons don't shrink #5582

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Mar 10, 2022

Hello @lizzthabet,

Please review the following commits I made in branch nicks/tooltip2:

4df5549 (2022-03-10 15:01:41 -0500)
web: fix the Mode tooltip, and make sure the tooltip icons don't shrink

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
Copy link
Member Author

nicks commented Mar 10, 2022

i restructured this a bit so that it doesn't rely on hard-coding the column text

Copy link
Contributor

@lizzthabet lizzthabet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nicks nicks merged commit 0451306 into master Mar 11, 2022
@nicks nicks deleted the nicks/tooltip2 branch March 11, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants