web: fix table view trigger mode button #5757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5754
This was broken by #5582 - the addition of
id
to the "mode" column definition caused the trigger mode to be written to RowValues as "mode" rather than "triggerMode", and this somehow didn't cause a compilation failure. The react-table docs around id vs accessor are not very clarifying, and I'm not sure it's worth getting to the bottom of that at the moment.I'm happy to hear if there's a more idiomatic way to write the test.