Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list_windows: We may be filtering out window_name: '' and '' values #445

Open
tony opened this issue Oct 2, 2022 · 0 comments
Open

list_windows: We may be filtering out window_name: '' and '' values #445

tony opened this issue Oct 2, 2022 · 0 comments

Comments

@tony
Copy link
Member

tony commented Oct 2, 2022 •
edited
Loading

#444 it seems the test will always pass, even before the change that, when verified by hand, permits window_name: '' to work (or else it'd default to zsh or whatever the shell name was for the window)

See if our filtering is negating '' as a falsey value. We want to keep those, if they exist.

Fulll context: #444 (comment)
@tony tony mentioned this issue Oct 2, 2022
Merged
@tony tony changed the title list_windows: Check to see if we're filtering out window_name: '' list_windows: We may be filtering out window_name: '' and '' values Oct 2, 2022
tony added a commit that referenced this issue Oct 2, 2022
@tony
fix: Allow empty window name in tmuxp (#444)
bd15984 
#445 will address and additional issue where formats of empty
strings are potentially being filtered out as if they held no value.

In re: tmux-python/tmuxp#822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tony