Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty window name #444

Merged
merged 4 commits into from
Oct 2, 2022
Merged

Allow empty window name #444

merged 4 commits into from
Oct 2, 2022

Conversation

ckt114
Copy link
Contributor

@ckt114 ckt114 commented Sep 26, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ckt114 ckt114 changed the title Allow empty window name. Allow empty window name Sep 26, 2022
@ckt114 ckt114 mentioned this pull request Sep 26, 2022
Closed
tony
tony reviewed Sep 26, 2022
View reviewed changes
src/libtmux/session.py Outdated Show resolved Hide resolved
@tony tony self-requested a review September 26, 2022 01:29
@tony tony self-assigned this Sep 26, 2022
@tony
Copy link
Member

tony commented Sep 26, 2022

@trankchung I am going to bed soon - I may not get to this until tomorrow

@codecov
Copy link

codecov bot commented Sep 26, 2022 •
edited
Loading

Codecov Report

Merging #444 (7fdb3f3) into master (f148a86) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   87.38%   87.44%   +0.05%     
==========================================
  Files          20       20              
  Lines        1792     1800       +8     
  Branches      246      246              
==========================================
+ Hits         1566     1574       +8     
  Misses        154      154              
  Partials       72       72
Impacted Files Coverage Δ
src/libtmux/session.py 76.43% <100.00%> (ø)
tests/test_window.py 97.86% <100.00%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ckt114
Copy link
Contributor Author

ckt114 commented Sep 26, 2022

@tony Would you review please?

tony
tony reviewed Sep 26, 2022
View reviewed changes
src/libtmux/session.py Outdated Show resolved Hide resolved
@tony tony self-requested a review October 2, 2022 17:53
@tony tony mentioned this pull request Oct 2, 2022
Open
tony
tony approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@tony tony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this by hand, this works well

Thank you @trankchung !

For the test, it's something on our side, I believe: #445. We're likely filtering out '' as if the filter had no value.

I will create a new release now for libtmux and tmuxp so you can try

@tony tony merged commit bd15984 into tmux-python:master Oct 2, 2022
tony added a commit that referenced this pull request Oct 2, 2022
@tony
Tag v0.15.8 (improvement for window_name: '' in tmuxp, #444)
f3d44d1 
In re: tmux-python/tmuxp#822
@tony
Copy link
Member

tony commented Oct 2, 2022

@trankchung v0.15.8

If you update libtmux by itself, tmuxp should work. You can verify libtmux version is 0.15.8 via tmuxp -V

(though its not pinned to 0.15.8 yet, doing that next)

tony added a commit to tmux-python/tmuxp that referenced this pull request Oct 2, 2022
@tony
build(deps): Bump libtmux 0.15.7 -> 0.15.8
c4b9c5a 
See also:
- tmux-python/libtmux#444
- Fixes #822
@tony
Copy link
Member

tony commented Oct 2, 2022

@trankchung This fixed is pinned in tmuxp v1.16.1

@ckt114
Copy link
Contributor Author

ckt114 commented Oct 4, 2022

Thanks @tony. I'm a long time tmuxinator user but I now prefer tmuxp more.

@tony
Copy link
Member

tony commented Oct 4, 2022

@trankchung welcome to the fold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tony tony tony approved these changes

Assignees

@tony tony

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckt114 @CLAassistant @tony