Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: finalize interface changes and enable deprecated warnings #9799

Closed
6 of 7 tasks
kddevin opened this issue Oct 11, 2021 · 2 comments
Closed
6 of 7 tasks

Tpetra: finalize interface changes and enable deprecated warnings #9799

kddevin opened this issue Oct 11, 2021 · 2 comments
Assignees
@kddevin
Labels
pkg: Tpetra type: enhancement Issue is an enhancement, not a bug UVM removal

Comments

@kddevin
Copy link
Contributor

kddevin commented Oct 11, 2021 •
edited by csiefer2
Loading

Enhancement

@trilinos/tpetra

Several Tpetra interfaces changed due to removal of the UVM requirement from Tpetra. To be user-friendly during Tpetra-stack conversion to the new interfaces, we suppressed the deprecation warnings. @trilinos/tpetra will review the remaining interfaces and decide which need to be deprecated as well. We will enable deprecation warnings as we go along.
@kddevin kddevin added type: enhancement Issue is an enhancement, not a bug pkg: Tpetra UVM removal labels Oct 11, 2021
@kddevin kddevin self-assigned this Oct 11, 2021
kddevin added a commit that referenced this issue Oct 11, 2021
@kddevin
tpetra: #9799 more changes to prevent Tpetra from spewing deprecation
c3bfdcc 
warnings from calls from deprecated functions to deprecated functions
kddevin added a commit that referenced this issue Oct 26, 2021
@kddevin
tpetra: #9799 deprecating constructors that take StaticProfile as arg…
f40d067 
…ument;

everything is static profile.
Removed StaticProfile and pftype from library
kddevin added a commit that referenced this issue Oct 27, 2021
@kddevin
tpetra: #9799 removing use of StaticProfile from Tpetra tests
1ad7b70
kddevin added a commit that referenced this issue Oct 27, 2021
@kddevin
tpetra: #9799 Fixed one test that was edited incorrectly.
7ad498f
kddevin added a commit that referenced this issue Oct 27, 2021
@kddevin
tpetra: #9799 removed use of deprecated Tpetra::StaticProfile
0a65290
kddevin added a commit that referenced this issue Oct 27, 2021
@kddevin
ifpack2: #9799 corrected use of deprecated getLocalRowCopy
66b594a
kddevin added a commit that referenced this issue Oct 27, 2021
@kddevin
Tpetra: deprecate and remove use of StaticProfile (#9865)
46303e5 
* tpetra:  #9799 deprecating constructors that take StaticProfile as argument;
everything is static profile.
Removed StaticProfile and pftype from library

* tpetra:  #9799 removing use of StaticProfile from Tpetra tests

* tpetra:  #9799  Fixed one test that was edited incorrectly.

* tpetra:  #9799 removed use of deprecated Tpetra::StaticProfile

* ifpack2:  #9799 corrected use of deprecated getLocalRowCopy
kddevin added a commit that referenced this issue Oct 27, 2021
@kddevin
tpetra: #9799 #9852 deprecating rsend and ssend options in Distributo…
e111636 
…r classes
kddevin added a commit that referenced this issue Oct 27, 2021
@kddevin
tpetra: #9799 #9852 added include file needed for
eb7e74a 
TPETRA_ENABLE_DEPRECATED_CODE macro
kddevin added a commit that referenced this issue Oct 28, 2021
@kddevin
tpetra: #9799 removed readySend and ssend options;
c6927b2 
if user requests deprecated option, default back to send
@kddevin kddevin mentioned this issue Oct 28, 2021
Merged
kddevin added a commit that referenced this issue Oct 29, 2021
@kddevin
tpetra: #9799 changed HAVE_TEUCHOS_DEBUG to HAVE_TPETRA_DEBUG
cd58c9d
trilinos-autotester added a commit that referenced this issue Oct 30, 2021
@trilinos-autotester
Merge Pull Request #9883 from trilinos/Trilinos/tpetra_deprecation_debug
94c15d4 
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: tpetra:  #9799 changed HAVE_TEUCHOS_DEBUG to HAVE_TPETRA_DEBUG
PR Author: kddevin
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Oct 31, 2021
Merge 'trilinos/Trilinos:develop' (94c15d4) into 'tcad-charon/Trilino…
6436d25 
…s:develop' (3f8d0b6).

* trilinos-develop: (34 commits)
  Update Krino for fixing parsing support when compiled with yaml-cpp (trilinos#9882)
  tpetra:  trilinos#9799 changed HAVE_TEUCHOS_DEBUG to HAVE_TPETRA_DEBUG
  intrepid2: resolve signed-unsigned warning
  Intrepid2 - deep copy range match
  Snapshot of kokkos-kernels.git from commit 14d29f0a04f9fc959c7c96d98e82fab3058d0ac0
  Snapshot of kokkos.git from commit 8dc4a906d43ae8eacc951cc5d7e95ad2dfa617dc
  tpetra:  fixed indexing error in describe() trilinos#9870 (trilinos#9874)
  STK: Snapshot 10-28-21 09:02
  MueLu: Removing superfluous cout
  stokhos: resolve -Werror
  Sacado: Use Kokkos::View<FadType> instead of Kokkos::View<FadType*> for singular Fad variables in Fad_KokkosTests and Fad_KokkosAtomicTests
  amesos2: resolve unused warning in superlu interface
  intrepid2: remove deprecation warnings
  Sacado: Run DFad tests for remaining Sacado tests
  Sacado: Fad_KokkosAtomicTests_Cuda_Hierarchical UVM free
  Sacado: Re-enable Sacado unit tests for UVM-Off PR tester
  Sacado: Make Sacado_FadKokkosTests_Cuda UVM free
  Add MPI_Finalize before return
  Check requested number of GPUs against available number of GPUs
  Enable using Cuda host pinned mem
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Oct 31, 2021
Merge 'trilinos/Trilinos:develop' (94c15d4) into 'tcad-charon/Trilino…
5d85ab5 
…s:develop' (3f8d0b6).

* trilinos-develop: (34 commits)
  Update Krino for fixing parsing support when compiled with yaml-cpp (trilinos#9882)
  tpetra:  trilinos#9799 changed HAVE_TEUCHOS_DEBUG to HAVE_TPETRA_DEBUG
  intrepid2: resolve signed-unsigned warning
  Intrepid2 - deep copy range match
  Snapshot of kokkos-kernels.git from commit 14d29f0a04f9fc959c7c96d98e82fab3058d0ac0
  Snapshot of kokkos.git from commit 8dc4a906d43ae8eacc951cc5d7e95ad2dfa617dc
  tpetra:  fixed indexing error in describe() trilinos#9870 (trilinos#9874)
  STK: Snapshot 10-28-21 09:02
  MueLu: Removing superfluous cout
  stokhos: resolve -Werror
  Sacado: Use Kokkos::View<FadType> instead of Kokkos::View<FadType*> for singular Fad variables in Fad_KokkosTests and Fad_KokkosAtomicTests
  amesos2: resolve unused warning in superlu interface
  intrepid2: remove deprecation warnings
  Sacado: Run DFad tests for remaining Sacado tests
  Sacado: Fad_KokkosAtomicTests_Cuda_Hierarchical UVM free
  Sacado: Re-enable Sacado unit tests for UVM-Off PR tester
  Sacado: Make Sacado_FadKokkosTests_Cuda UVM free
  Add MPI_Finalize before return
  Check requested number of GPUs against available number of GPUs
  Enable using Cuda host pinned mem
  ...
kddevin added a commit that referenced this issue Dec 7, 2021
@kddevin
Tpetra: deprecate readySend and Ssend options in Distributor (#9873)
d1004dd 
* tpetra: #9799 #9852 deprecating rsend and ssend options in Distributor classes

* tpetra:  #9799 #9852 added include file needed for
TPETRA_ENABLE_DEPRECATED_CODE macro

* tpetra:  #9852 enabled testing of Isend option in Distributor

* tpetra #9852 Changed behavior to use send instead of throwing when
user requests isend but data needs to be buffered for sending.

* tpetra:  #9799 removed readySend and ssend options;
if user requests deprecated option, default back to send

* Tpetra:  responding to review of #9873

* tpetra:  added behavior-change warnings in debug mode as requested in #9873

* tpetra:  removed barrier-between option as discussed in #9873
kddevin added a commit that referenced this issue Dec 13, 2021
@kddevin
tpetra: two changes needed for building without deprecated code #9799
78d8f56
@kddevin kddevin mentioned this issue Dec 13, 2021
Merged
kddevin added a commit that referenced this issue Dec 13, 2021
@kddevin
tpetra: fixed typo #9799
32bd63b
kddevin added a commit that referenced this issue Dec 17, 2021
@kddevin
Tpetra: Enable deprecated code warnings for capabilities changed duri…
155e45e 
…ng UVM-requirement removal (#10014)

* tpetra:  clean up deprecated warnings; remove obsolete field and its use

* tpetra:  #9799 more changes to prevent Tpetra from spewing deprecation
warnings from calls from deprecated functions to deprecated functions

* tpetra:  two changes needed for building without deprecated code #9799

* tpetra:  fixed typo #9799
kddevin added a commit that referenced this issue Feb 10, 2022
@kddevin
tpetra: #9799 Replaced deprecated CRS accessors with interfaces
61e8c5b 
consistent with UVM-free interfaces
Also fixed a CrsMatrix constructor that couldn't possibly work without UVM.
It was a copy constructor that tried to initialize using the source
matrix's device view, which would skew the use_count for the source
matrix, rendering it unusable.
@kddevin kddevin mentioned this issue Feb 14, 2022
Merged
kddevin added a commit that referenced this issue Feb 15, 2022
@kddevin
tpetra: Deprecating getNodeNumElements in favor of getLocalNumElements …
646a650 
…#9799
kddevin added a commit that referenced this issue Feb 15, 2022
@kddevin
tpetra: deprecate getNodeNumRows for getLocalNumRows #9799
e44648f
kddevin added a commit that referenced this issue Feb 15, 2022
@kddevin
tpetra deprecate getNodeNumCols for getLocalNumCols #9799
48e7f85 
Also some fixes for getNodeNumRows in RowMatrix and RowGraph
kddevin added a commit that referenced this issue Feb 15, 2022
@kddevin
tpetra: deprecating getNodeNumEntries for getLocalNumEntries #9799
63cfdea 
Also moved new functions above deprecated functions in decl files so
that doxygen will display the new function with documentation
kddevin added a commit that referenced this issue Feb 15, 2022
@kddevin
tpetra: deprecated getNodeElementList for getLocalElementList #9799
46047de
kddevin added a commit that referenced this issue Feb 15, 2022
@kddevin
tpetra: deprecate getNodeMaxNumRowEntries for getLocalMaxNumRowEntries …
3a519e5 
…#9799
kddevin added a commit that referenced this issue Feb 15, 2022
@kddevin
tpetra: minor spacing to make deprecations easier to find #9799
329912d
kddevin added a commit that referenced this issue Feb 15, 2022
@kddevin
tpetra: deprecate getNodeAllocationSize for getLocalAllocationSize #9799
7bf1588
kddevin added a commit that referenced this issue Feb 18, 2022
@kddevin
Tpetra: make CRS accessors consistent with UVM-free interface and fix…
f6bc414 
…ed matrix constructor (#10188)

* tpetra:  #9799  Replaced deprecated CRS accessors with interfaces
consistent with UVM-free interfaces
Also fixed a CrsMatrix constructor that couldn't possibly work without UVM.
It was a copy constructor that tried to initialize using the source
matrix's device view, which would skew the use_count for the source
matrix, rendering it unusable.

* tpetra:  fixed return type

* tpetra:  added device accessors for rowPtrs and Indices
Added unit test

* tpetra:  exercise more of the new interface

* tpetra:  added a test of the repaired matrix constructor

* tpetra:  fixed the macro names

* first cut at fixing downstream use of deprecations; does not yet compile

* Zoltan2:  Zoltan2 adapter uses Xpetra, whose interface isn't changing
for now.  So no interface changes are needed in Zoltan2.

* stokhos:  fixed new function names

* MueLu:  fix to allow compilation with new Tpetra interfaces

* tpetra:  minor changes addressing @tasmith4 's review comments #10188

* fixing compilation errors and warnings in PR testing of #10188

* ifpack2: one more compiler fix for #10188
kddevin added a commit that referenced this issue Feb 25, 2022
@kddevin
Tpetra: deprecate functions named getNode*, preferring more consisten…
75b4ba1 
…t getLocal* (#10189)

* tpetra:  Deprecating getNodeNumElements in favor of getLocalNumElements #9799

* tpetra:  deprecate getNodeNumRows for getLocalNumRows #9799

* tpetra deprecate getNodeNumCols for getLocalNumCols #9799
Also some fixes for getNodeNumRows in RowMatrix and RowGraph

* tpetra:  deprecating getNodeNumEntries for getLocalNumEntries #9799
Also moved new functions above deprecated functions in decl files so
that doxygen will display the new function with documentation

* tpetra:  deprecated getNodeElementList for getLocalElementList #9799

* tpetra:  deprecate getNodeMaxNumRowEntries for getLocalMaxNumRowEntries #9799

* tpetra:  minor spacing to make deprecations easier to find #9799

* tpetra:  deprecate getNodeAllocationSize for getLocalAllocationSize #9799

* tpetra:  fixed comment

* tpetra:  getNode* deprecation -- changes needed to support deprecated prototypes

* loca:  deprecated name replacement for #10189

* ifpack2:  deprecated name removal for #10189

* tpetra:  restored deprecated function for #10189

* zoltan2:  deprecated name replacement for #10189
@tasmith4
Copy link
Contributor

@csiefer2 guessing this can be closed now since #10552 is merged?

@csiefer2
Copy link
Member

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kddevin kddevin

Labels
pkg: Tpetra type: enhancement Issue is an enhancement, not a bug UVM removal
Projects
Tpetra
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@csiefer2 @kddevin @tasmith4